Skip to content

deprecate disable cache: no longer compatible with tests#617

Merged
artoonie merged 1 commit intomainfrom
deprecate-disable-cache
Apr 6, 2026
Merged

deprecate disable cache: no longer compatible with tests#617
artoonie merged 1 commit intomainfrom
deprecate-disable-cache

Conversation

@artoonie
Copy link
Copy Markdown
Owner

@artoonie artoonie commented Apr 6, 2026

Disabling cache causes some tests which test caching to fail. Deprecate it: it doesn't help much of the time and is not worth maintaining for the little benefit it gives.

@artoonie artoonie enabled auto-merge April 6, 2026 17:53
@artoonie artoonie merged commit 686d59d into main Apr 6, 2026
6 checks passed
@artoonie artoonie deleted the deprecate-disable-cache branch April 6, 2026 18:00
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.06%. Comparing base (0b93708) to head (67723a5).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #617      +/-   ##
==========================================
+ Coverage   95.48%   96.06%   +0.57%     
==========================================
  Files         131      132       +1     
  Lines        6141     6298     +157     
==========================================
+ Hits         5864     6050     +186     
+ Misses        277      248      -29     
Files with missing lines Coverage Δ
rcvis/settings.py 77.33% <100.00%> (+1.69%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b93708...67723a5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant