[SYSTEMDS-3259] Finalize Shampoo optimizer evaluation with experiments and improved tests#2433
Open
NicolasKorjahn wants to merge 4 commits intoapache:mainfrom
Open
[SYSTEMDS-3259] Finalize Shampoo optimizer evaluation with experiments and improved tests#2433NicolasKorjahn wants to merge 4 commits intoapache:mainfrom
NicolasKorjahn wants to merge 4 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch finalizes the Shampoo optimizer work by adding a reproducible experiment setup (MNIST/CIFAR-10) and improving tests for the Shampoo variants (baseline/momentum/heuristic, diagonal vs. non-diagonal where applicable), by automating existing tests.
The experiments log per-epoch metrics (loss/accuracy/time) and include scripts to visualize convergence and runtime tradeoffs across optimizers.