SOLR-18034: Add index-time nested vector expansion tests#4160
Open
arup-chauhan wants to merge 1 commit intoapache:mainfrom
Open
SOLR-18034: Add index-time nested vector expansion tests#4160arup-chauhan wants to merge 1 commit intoapache:mainfrom
arup-chauhan wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
Author
|
Hello everyone. This PR is for the index-time part of SOLR-18034 (test coverage validating multivalued dense vector expansion into nested children) Scope is intentionally narrow: this does not introduce new query-time behavior and keeps single-valued vector behavior unchanged, so risk is low, and boundaries stay aligned with related issues. If this split looks good, I’ll proceed with the follow-up lifecycle-safety work in a second PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds focused index-time test coverage for SOLR-18034 to validate how nested vector documents are constructed from multi-valued dense vectors.
The goal here is to make the existing behavior explicit and regression-safe before any broader lifecycle work.
Context from issue discussion
Issue: SOLR-18034
From the discussion, the scope is server-side indexing assistance for parent/child modeling of nested vectors (aligned with nested-vector direction from SOLR-17736, while avoiding overlap with broader multi-valued vector/query-time scope in SOLR-18074
This PR is intentionally scoped as PR-1: index-time behavior validation.
Changes
processing.
idformat_nest_parent__nest_path_Behavior / Safety
Validation
Executed and passing:
./gradlew :solr:core:test --tests org.apache.solr.update.TestNestedUpdateProcessor./gradlew tidy./gradlew check -x testResult: all commands completed successfully for this branch.
Follow-ups
Planned next step (PR-2), based on maintainer feedback: