SOLR-18039: Add byte-path parity tests for repeated parents.preFilter#4159
Open
arup-chauhan wants to merge 1 commit intoapache:mainfrom
Open
SOLR-18039: Add byte-path parity tests for repeated parents.preFilter#4159arup-chauhan wants to merge 1 commit intoapache:mainfrom
arup-chauhan wants to merge 1 commit intoapache:mainfrom
Conversation
Signed-off-by: Arup Chauhan <arupchauhan.connect@gmail.com>
Contributor
Author
|
Hey @epugh @alessandrobenedetti, as mentioned, here is the quick update:
This is test-only follow-up coverage; no parser/runtime behavior changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds parity coverage for
SOLR-18039by validating repeatedparents.preFilterbehavior on the byte-vector nested KNN paths. The core parser fix was merged in #4139, this follow-up keeps scope narrow to test coverage only.Context from issue discussion
In SOLR-18039, we fixed repeated
parents.preFilterhandling and added focused float-path coverage. The remaining gap was parity validation for equivalent byte-vector nested parent-retrieval flows, so this PR closes that gap without extending scope into parser refactoring yet.Changes
parents.preFilterin byte-vector nested parent retrieval.parents.preFilterin byte-vector nested parent retrieval with childpreFilter.Behavior / Safety
Validation
Ran with Java
21active (jenv/JAVA_HOMEset to21):./gradlew -p solr/core test --tests org.apache.solr.search.join.BlockJoinNestedVectorsQParserTest --tests org.apache.solr.search.join.BlockJoinNestedVectorsParentQParserTestOutcome:
BUILD SUCCESSFUL(:solr:core:test,17tests)../gradlew tidyOutcome:
BUILD SUCCESSFUL../gradlew check -x testOutcome:
BUILD SUCCESSFUL.Follow-ups
A separate small cleanup PR can still be done to consolidate shared filter-subquery parsing between
preFilterandparents.preFilterpaths, keeping behavior unchanged.