RANGER-5496: Decouple JWT lifecycle from Ranger plugin via pluggable JWT provider#857
Open
kumaab wants to merge 2 commits intoapache:masterfrom
Open
RANGER-5496: Decouple JWT lifecycle from Ranger plugin via pluggable JWT provider#857kumaab wants to merge 2 commits intoapache:masterfrom
kumaab wants to merge 2 commits intoapache:masterfrom
Conversation
mneethiraj
reviewed
Feb 24, 2026
|
|
||
| public class DefaultJwtProvider implements JwtProvider { | ||
| private static final Logger LOG = LoggerFactory.getLogger(DefaultJwtProvider.class); | ||
| public static final String JWT_SOURCE = ".policy.rest.client.jwt.source"; |
Contributor
There was a problem hiding this comment.
I suggest making .policy.rest.client part of propertyPrefix (line 48) to make this class generic for use in other contexts as well, like to fetch JWT to talk to services like Ranger KMS, Ranger RAZ, Ranger RMS, and other non-Ranger endpoints.
| String line = null; | ||
| while ((line = reader.readLine()) != null) { | ||
| if (StringUtils.isNotBlank(line) && !line.startsWith("#")) { | ||
| jwt = line; |
Contributor
There was a problem hiding this comment.
Introduce break; after line 71?
| String credAlias = config.get(propertyPrefix + JWT_CRED_ALIAS); | ||
| if (StringUtils.isNotEmpty(credFilePath) && StringUtils.isNotEmpty(credAlias)) { | ||
| String jwtFromCredFile = RangerCredentialProvider.getInstance().getCredentialString(credFilePath, credAlias); | ||
| if (StringUtils.isNotBlank(jwt)) { |
| private RangerAdminClient adminClient; | ||
|
|
||
| public RangerPluginContext(RangerPluginConfig config) { | ||
| this.config = config; |
Contributor
There was a problem hiding this comment.
Initialize DefaultJwtProvider instance with following call:
jwtProvider.setJwt(config.getPropertyPrefix() + ".policy.rest.client", config);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently JWT is fetched during plugin initialization (via 3 different ways: env, file, cred file) and captured statically in the REST client filter. This enhancement introduces a pluggable JWT provider interface allowing services to manage JWT lifecycle independently while enabling Ranger plugins to fetch the latest JWT dynamically for each outbound REST call to Ranger Admin. PR includes a default implementation of
JwtProvider.How was this patch tested?
Pending