Skip to content

MINOR: Fix formatting in parquet.thrift file (trailing spaces)#558

Open
OmBiradar wants to merge 1 commit intoapache:masterfrom
OmBiradar:parquet.thrift-formatting-error
Open

MINOR: Fix formatting in parquet.thrift file (trailing spaces)#558
OmBiradar wants to merge 1 commit intoapache:masterfrom
OmBiradar:parquet.thrift-formatting-error

Conversation

@OmBiradar
Copy link

@OmBiradar OmBiradar commented Mar 12, 2026

There were many trailing spaces here and there,
they have been removed.

Rationale for this change

Used the zed editors linter to format the document - removing any trailing spaces.

What changes are included in this PR?

Just removed the trailing spaces.

There were many trailing spaces here and there,
they have been removed.

Signed-off-by: OmBiradar <ombiradar04@gmail.com>
@OmBiradar OmBiradar changed the title Fix formatting in parquet.thrift file (trailing spaces) MINOR: Fix formatting in parquet.thrift file (trailing spaces) Mar 12, 2026
@OmBiradar
Copy link
Author

original issue - apache-arrow-issue-49501

requesting your review @alamb

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THis is a nice cleanup in my opinion

Thank you @OmBiradar

@alamb
Copy link
Contributor

alamb commented Mar 12, 2026

(I'll leave this open for a while to make sure other committers have a chance to review if they would like)

Copy link
Member

@wgtmac wgtmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me. I know the intention is good but I don't know if anyone really cares about the original commit history.

@OmBiradar
Copy link
Author

OmBiradar commented Mar 12, 2026

@alamb @wgtmac

Should I add a new CI task to check the linting in this PR itself?

@alamb
Copy link
Contributor

alamb commented Mar 12, 2026

@alamb @wgtmac

Should I add a new CI task to check the linting in this PR itself?

No, if you want to propose a new CI please use a new PR. I am not sure we are likely to add new CI 🤔

@alamb
Copy link
Contributor

alamb commented Mar 12, 2026

+1 from me. I know the intention is good but I don't know if anyone really cares about the original commit history.

The commit history will be retained, but just using git blame directly will be harder to interpret (will require more archeology)

@OmBiradar
Copy link
Author

What if we add a new '.git-blame-ignore-revs' file that will help avoid these formatting/linting related commits to interfear with the 'git blame'

https://www.git-tower.com/blog/how-to-exclude-commits-from-git-blame#:~:text=You%20can%20do%20this%20by,ignoreRevsFile%20configuration%20option.&text=With%20this%20configuration%20in%20place,blame%2Dignore%2Drevs%20file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants