HDDS-14627. Code cleanup in TestVolumeSet#9769
Open
Russole wants to merge 1 commit intoapache:masterfrom
Open
Conversation
Contributor
Gargi-jais11
left a comment
Gargi-jais11
left a comment
There was a problem hiding this comment.
Thanks @Russole for the patch. Overall LGTM!
Just one comment to resolve.
| assertEquals(2, volumeSet.getVolumesList().size()); | ||
|
|
||
| // Add a volume to VolumeSet | ||
| String volume3 = baseDir + "disk3"; |
Contributor
There was a problem hiding this comment.
Nit: Let's make this consistent with how other volumes are added.
Suggested change
| String volume3 = baseDir + "disk3"; | |
| String volume3 = baseDir.resolve("disk3").toString(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14627
How was this patch tested?