ORC-1662: [C++] Upgrade protobuf to 3.21.12#1857
Open
ffacs wants to merge 14 commits intoapache:mainfrom
Open
Conversation
Member
|
Thanks for the PR! Unfortunately the new protobuf version is not compatible to compile libhdfspp. Let me investigate this. |
Member
|
Update: I tried to upgrade libhdfspp. But unfortunately, I ran this command https://github.com/apache/orc/blob/main/c%2B%2B/libs/libhdfspp/pull_hdfs.sh#L25 without check. It wiped out my current directory (which is the root user profile). |
Member
|
Oh, too bad for the accident. |
### What changes were proposed in this pull request? This PR aims to setting version to 3.0.0-SNAPSHOT. ### Why are the changes needed? Since `branch-2.3` is created, we need to bump `main` branch for next release. - https://github.com/apache/orc/tree/branch-2.3 ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: `Gemini 3.1 Pro (High)` on `Antigravity` Closes apache#2541 from dongjoon-hyun/ORC-2100. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
### What changes were proposed in this pull request? This PR aims to remove HDFS support code from Apache ORC repository. ### Why are the changes needed? Apache ORC 2.0.1 deprecated HDFS Support to address the following issues. - apache#1885 - apache#1857 - apache#2134 ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: `Gemini 3.1 Pro (High)` on `Antigravity` This closes apache#2136 . Closes apache#2544 from dongjoon-hyun/ORC-2102. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
|
Could you rebase this PR, @ffacs ? |
### What changes were proposed in this pull request? This PR aims to update CMake requirements to 3.25+ consistently. ### Why are the changes needed? We had better fix these outdated information because we already bumped the minimum requirement to 3.25+. - apache#2416 ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: `Gemini 3.1 Pro (High)` on `Antigravity` Closes apache#2545 from dongjoon-hyun/ORC-2103. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
### What changes were proposed in this pull request? This PR aims to update `amazonlinux` with `2023.10.20260202.2` and use `dnf` instead of `yum`. ### Why are the changes needed? To use the latest `Amazon Linux` version. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: `Gemini 3.1 Pro (High)` on `Antigravity` Closes apache#2546 from dongjoon-hyun/ORC-2104. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
### What changes were proposed in this pull request? This PR aims to fix `orc-format.wrap` to use ORC Format 1.1.1. ### Why are the changes needed? To be consistent with the other modules. - apache#2355 - apache#2474 ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: `Gemini 3.1 Pro (High)` on `Antigravity` Closes apache#2547 from dongjoon-hyun/ORC-2105. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
### What changes were proposed in this pull request? This PR aims to add `Build Status` table of all live branches to `README.md`. ### Why are the changes needed? To improve the visibility of all live release branches. ### How was this patch tested? Check the PR branch. - https://github.com/dongjoon-hyun/orc/tree/ORC-2106 <img width="370" height="382" alt="Screenshot 2026-02-22 at 21 02 28" src="https://github.com/user-attachments/assets/b61922ca-6c63-4943-87f2-eaf1caa4365b" /> ### Was this patch authored or co-authored using generative AI tooling? Generated-by: `Gemini 3.1 Pro (High)` on `Antigravity` Closes apache#2549 from dongjoon-hyun/ORC-2106. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
### What changes were proposed in this pull request? This PR aims to improve `create_orc_jira.py` to support types and parents. ### Why are the changes needed? To make the JIRA issue creation easier. ### How was this patch tested? Manual test. ``` $ dev/create_orc_jira.py 'Improve `create_orc_jira.py` to support types and parents' Creating JIRA issue with title: Improve `create_orc_jira.py` to support types and parents Created JIRA issue: ORC-2107 git checkout -b ORC-2107 Switched to a new branch 'ORC-2107' Created and checked out branch: ORC-2107 ['git', 'commit', '-a', '-m', 'ORC-2107: Improve `create_orc_jira.py` to support types and parents'] Created a commit with message: ORC-2107: Improve `create_orc_jira.py` to support types and parents ``` ### Was this patch authored or co-authored using generative AI tooling? Generated-by: `Gemini 3.1 Pro (High)` on `Antigravity` Closes apache#2551 from dongjoon-hyun/ORC-2107. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
…d enable retries ### What changes were proposed in this pull request? This PR aims to add a generic connection and read timeout parameter timeout=(3.05, 30) to the `jira.client.JIRA()` initializations in the dev/ scripts: - `create_orc_jira.py` - `merge_orc_pr.py` ### Why are the changes needed? By default, the requests library (used by the jira python package) can hang indefinitely when attempting to establish a connection if the server is unresponsive. Setting a short connection timeout of 3.05 seconds (slightly larger than a standard 3-second TCP packet retransmission window) ensures that the client will quickly fail the connection attempt and properly trigger its internal retry logic, rather than stalling the entire script. The 30-second read timeout allows sufficient time for normal API responses once the connection is successfully established. ### How was this patch tested? Manual tests. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: `Gemini 3.1 Pro (High)` on `Antigravity` Closes apache#2552 from dongjoon-hyun/ORC-2108. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
### What changes were proposed in this pull request? This PR aims to improve `create_orc_jira.py` to support the version parameter. ### Why are the changes needed? To accept `Affected Version` for `Bug` type issues easily. ### How was this patch tested? Manual tests. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: `Gemini 3.1 Pro (High)` on `Antigravity` Closes apache#2554 from dongjoon-hyun/ORC-2109. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Co-authored-by: Cursor <cursoragent@cursor.com>
Guard alias creation for protobuf::libprotobuf and protobuf::protoc to avoid duplicate target errors when Protobuf >= 3.21 already exports them. Also mark protobuf headers as SYSTEM to suppress compiler warnings from protobuf code. Co-authored-by: Cursor <cursoragent@cursor.com>
Align the meson build protobuf version with the CMake build (3.21.12) using the latest wrapdb patch (3.21.12-5). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Upgrade protobuf to 3.21.12
Why are the changes needed?
To fix compilation failure on vs2022
How was this patch tested?
UT passed
Was this patch authored or co-authored using generative AI tooling?
NO