Fixed Compile On Save in Java SE Project on application running or debugging Fixed Java Debugger did not apply the code change in Java SE Project if the project is Java source version 8 Fixed JSP Java Code analyzer in Java SE Project Improved JSP Hyperlink provider#9013
Fixed Compile On Save in Java SE Project on application running or debugging Fixed Java Debugger did not apply the code change in Java SE Project if the project is Java source version 8 Fixed JSP Java Code analyzer in Java SE Project Improved JSP Hyperlink provider#9013steelswing wants to merge 3 commits intoapache:masterfrom
Conversation
|
I'm willing to have a look at this. But these are three totally unrelated changes, that should not be in the same PR. Please split them. When creating the new PRs, please keep unrelated changes to a minimum. Whitespace without relation to the changed code should not be changed (there are exceptions to the rule, but it would be good not to go down that route), debugging only changes should be removed (there is no need to mess with log levels), commented out code should not be part of additions. Please also ensure that there is full author information available, currently there is a nickname instead of the author information. |
donphelix
left a comment
donphelix
left a comment
There was a problem hiding this comment.
I think we can drop these comments. With clear naming and proper spacing, the code should be self-explanatory.
|
|
||
| // private void checkPreprocessors(FileObject fileObject) { | ||
| // CssPreprocessors.getDefault().process(p, fileObject); | ||
| // } | ||
| // | ||
| // private void checkPreprocessors(FileObject fileObject, String originalName, String originalExtension) { | ||
| // CssPreprocessors.getDefault().process(p, fileObject, originalName, originalExtension); | ||
| // } |
There was a problem hiding this comment.
@steelswing would it make sense to remove this entirely rather than commenting it out? Might keep things cleaner.
There was a problem hiding this comment.
This is for the future if you need it
| FileObject root = group.getRootFolder(); | ||
| objects.add(root); | ||
| } | ||
| objects.add(project.getProjectDirectory()); |
|
|
||
| @Override | ||
| public void fileRenamed(FileRenameEvent fe) { | ||
| // XXX: notify BrowserReload about filename change |
3 participants
Fixed Compile On Save in Java SE Project on application running or debugging
Fixed Java Debugger did not apply the code change in Java SE Project if the project is Java source version 8
Fixed JSP Java Code analyzer in Java SE Project
Improved JSP Hyperlink provider
^Add meaningful description above
Click to collapse/expand PR instructions
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)