Skip to content

[Doc] PR policy and Review Guidelines#1122

Merged
400Ping merged 6 commits intoapache:mainfrom
400Ping:doc/PR-policy-review-guidelines
Mar 8, 2026
Merged

[Doc] PR policy and Review Guidelines#1122
400Ping merged 6 commits intoapache:mainfrom
400Ping:doc/PR-policy-review-guidelines

Conversation

@400Ping
Copy link
Member

@400Ping 400Ping commented Mar 5, 2026

Related Issues

Closes #901

Changes

  • Bug fix
  • New feature
  • Refactoring
  • Documentation
  • Test
  • CI/CD pipeline
  • Other

Why

How

Checklist

  • Added or updated unit tests for all changes
  • Added or updated documentation for all changes

Signed-off-by: 400Ping <jiekaichang@apache.org>
@400Ping 400Ping marked this pull request as draft March 5, 2026 08:36
400Ping added 2 commits March 5, 2026 16:42
Signed-off-by: 400Ping <jiekaichang@apache.org>
Signed-off-by: 400Ping <jiekaichang@apache.org>
@400Ping 400Ping marked this pull request as ready for review March 5, 2026 08:45
@400Ping 400Ping self-assigned this Mar 5, 2026
@ryankert01
Copy link
Member

We probably can reference to data fusions' ai policy. I think it's great

@400Ping
Copy link
Member Author

400Ping commented Mar 5, 2026

We probably can reference to data fusions' ai policy. I think it's great

Mind give me the link for it?

@ryankert01
Copy link
Member

https://datafusion.apache.org/contributor-guide/index.html#ai-assisted-contributions

Copy link
Member

@guan404ming guan404ming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice but would be appreciate if there are another pair of eyes on this!

@guan404ming
Copy link
Member

cc @rich7420 @viiccwen

Copy link
Contributor

@viiccwen viiccwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg!

Copy link
Contributor

@rich7420 rich7420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rich7420 rich7420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wait I saw @ryankert01 's comment, ai assistant rules is important one.

@400Ping
Copy link
Member Author

400Ping commented Mar 6, 2026

oh wait I saw @ryankert01 's comment, ai assistant rules is important one.

I already wrote a section about it. Will refractor it a little later.

@bearomorphism
Copy link
Contributor

In commitizen-tools, we even have a big section about AI-assisted PRs

https://commitizen-tools.github.io/commitizen/contributing/pull_request/

ryankert01 and others added 3 commits March 7, 2026 11:01
Signed-off-by: 400Ping <jiekaichang@apache.org>
@400Ping 400Ping merged commit 587a1d9 into apache:main Mar 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Docs] PR policy and review guidelines

6 participants