Skip to content

Conversation

@Arkelenia
Copy link
Contributor

@Arkelenia Arkelenia commented Mar 16, 2025

Use the fully-qualified name for the GCP IMDS endpoint

Description

This PR replaces the current IMDS endpoint http://metadata/computeMetadata/v1/... with the fully-qualified name version http://metadata.google.internal/computeMetadata/v1/....

The current state assumes the presence of google.internal as a search domain to work properly which may not be the case when the endpoint is resolved from a container or a Kubernetes pod running on a GCP node.

Status

ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

Copy link
Contributor

@micafer micafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 83.35%. Comparing base (6a7f04a) to head (b6f6772).

Files with missing lines Patch % Lines
libcloud/common/google.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            trunk    #2060   +/-   ##
=======================================
  Coverage   83.35%   83.35%           
=======================================
  Files         353      353           
  Lines       81848    81848           
  Branches     8998     8998           
=======================================
  Hits        68224    68224           
  Misses      10797    10797           
  Partials     2827     2827           
Files with missing lines Coverage Δ
libcloud/common/google.py 71.35% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@micafer micafer merged commit 84206fb into apache:trunk Feb 11, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants