RcodeZero Driver: fix issue when adding a record where a record with a different type already exists #2038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Could you please merge this documentation PR too? |
Member
|
@MikeAT Thanks for the contribution. Would it be possible to add a unit test case for this fix? |
Member
|
@MikeAT The documentation PR has been merged. It looks like the existing tests are failing. It would be great if you could look into that (you likely need to add mock response fixtures for v2 API responses and implement corresponding methods on the MockHttp class) and add a (regression) test case for a bug this PR is fixing. Thanks. |
Contributor
Author
|
Hi @Kami, sorry, I forgot to commit the API v2 tests. And I added the regression test for the fixed bug. |
MikeAT
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #2038 +/- ##
==========================================
- Coverage 83.35% 83.35% -0.00%
==========================================
Files 353 353
Lines 81848 81858 +10
Branches 8998 8999 +1
==========================================
+ Hits 68224 68232 +8
- Misses 10797 10798 +1
- Partials 2827 2828 +1
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RcodeZero: Bugfix when adding a record where a record with a different type already exists
Description
The RcodeZero driver generated broken API-Requests when adding records with different type (eg. adding an AAAA record to an existing A record). This PR fixes #2042:
Status
Done, ready for review
Checklist (tick everything that applies)