KNOX-3277 : LDAP Proxy improvements for working with AD backend#1177
Open
handavid wants to merge 1 commit intoapache:masterfrom
Open
KNOX-3277 : LDAP Proxy improvements for working with AD backend#1177handavid wants to merge 1 commit intoapache:masterfrom
handavid wants to merge 1 commit intoapache:masterfrom
Conversation
The LdapProxyBackend and GroupLookupInterceptors are updated to work with sAMAccountName in addition to uid and cn for user and group lookup. This involved adding the memberOf and sAMAccountName attribute types to the schema used by the proxy. Group retrieval during user search is fixed to respect the useMemberOf flag. Tests for the LdapProxyBackend were added.
Author
Test Results7 tests 7 ✅ 1s ⏱️ Results for commit 1c9e356. |
lmccay
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KNOX-3277 LDAP Proxy improvements for working with AD backend
What changes were proposed in this pull request?
The LdapProxyBackend and GroupLookupInterceptors are updated to work with sAMAccountName in addition to uid and cn for user and group lookup. This involved adding the memberOf and sAMAccountName attribute types to the schema used by the proxy.
Group retrieval during user search is fixed to respect the useMemberOf flag.
Tests for the LdapProxyBackend were added.
How was this patch tested?
Changes were manually tested by running
ant start-test-gatewayconfigured against both AD and the test LDAP server.Unit tests were added to cover the LdapProxyBackend behavior.