Conversation
|
Thank you! |
|
Three depencies are not updated for 10 yet and gives warnings: After update there are also some new lint errors: Since jena has implemented/moved into the flat config file described in https://eslint.org/docs/latest/use/configure/migration-guide I think the old style rc files are not read. Therefore I think these are currently not used/picked up (also in main): and have to be migrated to the flat format ( However the ci job that runs lint also just uses |
7408766 to
9995f5e
Compare
…encies * update eslint-config-standard to 8.0.1 -> 9.0.1 (not updated for 10 yet) * use caret for eslint 10 to update package lock later * delete eslint-plugin-standard (removed, part of other dependencies afaik) * update plugin-vue 9.17.0 -> 10.8.0 * add unmet peer dependency for typescript (from eslint-config-standard 9) * add unmet peer dependency for vue-eslint-parser (from upgraded eslint-plugin-vue) * Add globals (browser) dependency to eslint-config for defined browser objects * Update ecma version (maybe uneccessary, suggested by LLM from warnings in IDE, didnt solve) * Rethrow cause for lint error (preserve-caught-error)
4063592 to
f688820
Compare
|
This should be ready for review. Would you have the time to check if the javascript specific changes looks ok @kinow? I'm not that confident in the Jena-UI and node parts of the application, since I don't do much similar things elsewhere. Fixed the new eslint errors by adding browser to globals, and adding the cause back to the Error(msg,cause). Some things could have a followup (or removing dependencies?) if my assumptions are correct that some eslint config files aren't read. |
|
I pulled the PR, didn't rebase to latest main (see conflict), did a build and ran the server. From an incognito window, I uploaded data (first attempt - got an error wanting a graph name of blank when it was blank - IIRC this is not new; second time upload worked), and did a query. It worked 😄 |
GitHub issue resolved #
Pull request Description:
Dependabot fails build for eslint. Investigating why.
If eslint also has an updated version and updated lockfile, the CI runs successfully (https://github.com/OyvindLGjesdal/jena/actions/runs/22578692265)
However there are some other issues/warnings, that should probably be updated with the new version.
lockfile updated with
eslint-plugin-standard no longer in use: https://www.npmjs.com/package/eslint-plugin-standard (can probably just remove)
Will try to update also rest of dependencies.
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.
See the Apache Jena "Contributing" guide.