fix(integration): prevent flaky connector sink tests from f64 round-trip mismatch#2838
Merged
fix(integration): prevent flaky connector sink tests from f64 round-trip mismatch#2838
Conversation
…rip mismatch The serde_json (Ryu) and simd_json serializers format non-exact f64 values differently. Multiplying by 99.99 produced values like 1099.89 that round-tripped as 1099.8899999999999 through the connector SDK's simd_json path, causing assertion failures in Quickwit sink tests. Multiplying by 100.0 produces exact integers (0.0, 100.0, 200.0, ...) that all IEEE 754 serializers represent identically.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2838 +/- ##
============================================
+ Coverage 67.66% 67.68% +0.02%
Complexity 708 708
============================================
Files 1030 1030
Lines 83846 83846
Branches 60704 60704
============================================
+ Hits 56733 56751 +18
+ Misses 24765 24746 -19
- Partials 2348 2349 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
spetz
approved these changes
Mar 1, 2026
mmodzelewski
approved these changes
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The serde_json (Ryu) and simd_json serializers format
non-exact f64 values differently. Multiplying by 99.99
produced values like 1099.89 that round-tripped as
1099.8899999999999 through the connector SDK's
simd_json path, causing assertion failures in Quickwit
sink tests.
Multiplying by 100.0 produces exact integers (0.0,
100.0, 200.0, ...) that all IEEE 754 serializers
represent identically.