Skip to content

fix(integration): prevent flaky connector sink tests from f64 round-trip mismatch#2838

Merged
hubcio merged 1 commit intomasterfrom
qw-toggler
Mar 1, 2026
Merged

fix(integration): prevent flaky connector sink tests from f64 round-trip mismatch#2838
hubcio merged 1 commit intomasterfrom
qw-toggler

Conversation

@hubcio
Copy link
Contributor

@hubcio hubcio commented Mar 1, 2026

The serde_json (Ryu) and simd_json serializers format
non-exact f64 values differently. Multiplying by 99.99
produced values like 1099.89 that round-tripped as
1099.8899999999999 through the connector SDK's
simd_json path, causing assertion failures in Quickwit
sink tests.

Multiplying by 100.0 produces exact integers (0.0,
100.0, 200.0, ...) that all IEEE 754 serializers
represent identically.

…rip mismatch

The serde_json (Ryu) and simd_json serializers format
non-exact f64 values differently. Multiplying by 99.99
produced values like 1099.89 that round-tripped as
1099.8899999999999 through the connector SDK's
simd_json path, causing assertion failures in Quickwit
sink tests.

Multiplying by 100.0 produces exact integers (0.0,
100.0, 200.0, ...) that all IEEE 754 serializers
represent identically.
@codecov
Copy link

codecov bot commented Mar 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.68%. Comparing base (71eb4d5) to head (8fa5304).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2838      +/-   ##
============================================
+ Coverage     67.66%   67.68%   +0.02%     
  Complexity      708      708              
============================================
  Files          1030     1030              
  Lines         83846    83846              
  Branches      60704    60704              
============================================
+ Hits          56733    56751      +18     
+ Misses        24765    24746      -19     
- Partials       2348     2349       +1     
Flag Coverage Δ
rust 69.72% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hubcio hubcio merged commit 7ebce1b into master Mar 1, 2026
48 checks passed
@hubcio hubcio deleted the qw-toggler branch March 1, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants