You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Brings the UsersClient interface in the async package up to parity with the UsersClient in the blocking package. Implements all the new methods in the async TCP implementation.
What changed?
Prior to this PR, only the login and logout methods were available on the async UsersClient whereas the blocking version had another ~7 methods (plus overloads). This PR adds the missing methods and implements them along with integration tests, bringing the async version of UsersClient to parity with the blocking version. I also implemented some helper methods on AsyncTcpConnection, similar to those on the blocking InternalTcpClient to make the new methods and any future methods a bit more succinct.
Local Execution
Passed
Pre-commit hooks - I installed prek after pushing up my code but noticed that it doesn't seem to support Java when I ran it.
AI Usage
Only AI usage was Jetbrains local models for full line code completion. Verified code works correctly by running tests and eyeballing it. I could explain every line if asked.
mmodzelewski
changed the title
feat(java-sdk) Adds missing methods to async TCP UsersClient
feat(java): add missing methods to async TCP UsersClient
Feb 28, 2026
❌ Patch coverage is 95.58824% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.61%. Comparing base (7ebce1b) to head (86d2ed7). ⚠️ Report is 1 commits behind head on master.
@jrhenderson1988 Thanks for the PR. I've updated the PR title to match our CI checks. Please verify that the ASF licence headers are inserted in all files. You can easily fix that with ./scripts/ci/license-headers.sh --fix
No worries, thanks for updating that @mmodzelewski - I've just added the ASF header where it was missing now. I seem to be having problems running the pre-push hook with prek as it appears to be failing to install some kind of Go linting tool. I've just pushed with --no-verify for now while I try to get it working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2826
Rationale
Brings the
UsersClientinterface in the async package up to parity with theUsersClientin the blocking package. Implements all the new methods in the async TCP implementation.What changed?
Prior to this PR, only the
loginandlogoutmethods were available on the asyncUsersClientwhereas the blocking version had another ~7 methods (plus overloads). This PR adds the missing methods and implements them along with integration tests, bringing the async version ofUsersClientto parity with the blocking version. I also implemented some helper methods onAsyncTcpConnection, similar to those on the blockingInternalTcpClientto make the new methods and any future methods a bit more succinct.Local Execution
AI Usage
Only AI usage was Jetbrains local models for full line code completion. Verified code works correctly by running tests and eyeballing it. I could explain every line if asked.