Skip to content

feat(java): add missing methods to async TCP UsersClient#2837

Merged
mmodzelewski merged 8 commits intoapache:masterfrom
jrhenderson1988:issue-2826-users-client
Mar 1, 2026
Merged

feat(java): add missing methods to async TCP UsersClient#2837
mmodzelewski merged 8 commits intoapache:masterfrom
jrhenderson1988:issue-2826-users-client

Conversation

@jrhenderson1988
Copy link
Contributor

Which issue does this PR close?

Closes #2826

Rationale

Brings the UsersClient interface in the async package up to parity with the UsersClient in the blocking package. Implements all the new methods in the async TCP implementation.

What changed?

Prior to this PR, only the login and logout methods were available on the async UsersClient whereas the blocking version had another ~7 methods (plus overloads). This PR adds the missing methods and implements them along with integration tests, bringing the async version of UsersClient to parity with the blocking version. I also implemented some helper methods on AsyncTcpConnection, similar to those on the blocking InternalTcpClient to make the new methods and any future methods a bit more succinct.

Local Execution

  • Passed
  • Pre-commit hooks - I installed prek after pushing up my code but noticed that it doesn't seem to support Java when I ran it.

AI Usage

Only AI usage was Jetbrains local models for full line code completion. Verified code works correctly by running tests and eyeballing it. I could explain every line if asked.

@mmodzelewski mmodzelewski changed the title feat(java-sdk) Adds missing methods to async TCP UsersClient feat(java): add missing methods to async TCP UsersClient Feb 28, 2026
@codecov
Copy link

codecov bot commented Feb 28, 2026

Codecov Report

❌ Patch coverage is 95.58824% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.61%. Comparing base (7ebce1b) to head (86d2ed7).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ache/iggy/client/async/tcp/AsyncTcpConnection.java 88.88% 1 Missing and 1 partial ⚠️
...g/apache/iggy/client/async/tcp/UsersTcpClient.java 97.77% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2837      +/-   ##
============================================
+ Coverage     67.65%   68.61%   +0.96%     
- Complexity      708      739      +31     
============================================
  Files          1030      748     -282     
  Lines         83846    62265   -21581     
  Branches      60704    58428    -2276     
============================================
- Hits          56722    42724   -13998     
+ Misses        24771    17426    -7345     
+ Partials       2353     2115     -238     
Flag Coverage Δ
csharp ?
go ?
java 54.83% <95.58%> (+0.81%) ⬆️
node ?
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...java/org/apache/iggy/client/async/UsersClient.java 100.00% <100.00%> (ø)
...g/apache/iggy/client/async/tcp/UsersTcpClient.java 98.55% <97.77%> (+21.62%) ⬆️
...ache/iggy/client/async/tcp/AsyncTcpConnection.java 62.50% <88.88%> (+4.31%) ⬆️

... and 329 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mmodzelewski
Copy link
Member

@jrhenderson1988 Thanks for the PR. I've updated the PR title to match our CI checks. Please verify that the ASF licence headers are inserted in all files. You can easily fix that with ./scripts/ci/license-headers.sh --fix

@jrhenderson1988
Copy link
Contributor Author

No worries, thanks for updating that @mmodzelewski - I've just added the ASF header where it was missing now. I seem to be having problems running the pre-push hook with prek as it appears to be failing to install some kind of Go linting tool. I've just pushed with --no-verify for now while I try to get it working.

@mmodzelewski mmodzelewski merged commit 29a27cc into apache:master Mar 1, 2026
45 checks passed
@mmodzelewski
Copy link
Member

Cheers @jrhenderson1988, that's now in master.

@jrhenderson1988 jrhenderson1988 deleted the issue-2826-users-client branch March 1, 2026 12:33
@jrhenderson1988
Copy link
Contributor Author

No worries - thanks for merging 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Java SDK] Async UsersClient missing methods

3 participants