Conversation
|
hi @rambleraptor I came across this PR from the attached issue and am interested in helping this effort move forward. It looks like there are still some "todo" items in this implementation and it's not immediately clear to me if you're still working on this or are waiting on review etc. I'd be happy to give a more thorough review against the spec if that's something you're needing to push forward on this. Otherwise, is there anything I can do to help move this along? |
|
I came across this PR because we wanted to implement geospatial columns for our fork of icebeg-rust (lakekeeper/lakekeeper#1579) that we are using in Lakekeeper. We already provided a PR for partial support of the VARIANT type (#2188) I made some additions to your changes because I think there where Edge Interpolation Algorithms missing for the GEOGRAPHY type. Also I couldn't find the If you find those changes usefull you can find them here: https://github.com/brgr-s/iceberg-rust/tree/feat/geo-types-support I think the biggest obstacle is that Spark 4.1 does not yet support geospatial types, so we can't integration test the feature at the moment. |
|
Would you mind if I fork this to add a geo types example? |
Which issue does this PR close?
What changes are included in this PR?
This gets the ball rolling with parsing the Geography + Geometry types. I'd love to hear any advice you might have!
Are these changes tested?
Unit tests are included.