modernize CSS with flexbox and smooth transitions#420
modernize CSS with flexbox and smooth transitions#420sanjana2505006 wants to merge 1 commit intoapache:masterfrom
Conversation
|
Please let me know if any adjustments are needed |
|
@jamesfredley assume you intend to look at this one? |
assets/stylesheets/screen.css
Outdated
| url('../fonts/roboto-regular.woff') format('woff'), /* Pretty Modern Browsers */ | ||
| url('../fonts/roboto-regular.ttf') format('truetype'), /* Safari, Android, iOS */ | ||
| url('../fonts/roboto-regular.svg#svgFontName') format('svg'); /* Legacy iOS */ | ||
| src: url('../fonts/roboto-regular.eot'); |
There was a problem hiding this comment.
Comments that were previously related to the line, is now looking like they are related to the line below. Generally there are too many unneeded white-space changes
There was a problem hiding this comment.
Thank you for catching that! It looks like my code editor automatically reformatted the entire file and shifted all those comments out of place. I just force-pushed an update that undoes all those accidental whitespace changes and only keeps the functional flexbox/transition updates. It should be perfectly clean for review now!
|
The PR makes extensive whitespace changes in screen.css, such as moving inline comments to separate lines, adjusting tab/space indentation, and adding blank lines between @font-face blocks. These modifications can shift line numbers, causing existing review comments to appear misaligned with their original lines. To minimize disruption, consider limiting changes to functional code and avoiding purely cosmetic whitespace edits. |
sanjana2505006
force-pushed
the
feature/modernize-css
branch
from
934ed51 to
ca021e7
Compare
4 participants
Updated the CSS to be more modern. Switched the layout from using floats to Flexbox so it's less brittle. Also added smooth transitions to buttons/links and cleaned up a bunch of old browser prefixes we don't need anymore.