fix(udf): handle Integer.MIN_VALUE in Substr function#759
Open
SYaoJun wants to merge 1 commit intoapache:masterfrom
Open
fix(udf): handle Integer.MIN_VALUE in Substr function#759SYaoJun wants to merge 1 commit intoapache:masterfrom
SYaoJun wants to merge 1 commit intoapache:masterfrom
Conversation
Leomrlin
reviewed
Mar 5, 2026
| Substr sb = new Substr(); | ||
|
|
||
| // Test Integer.MIN_VALUE for String version | ||
| Assert.assertEquals(sb.eval("hello", Integer.MIN_VALUE, 1), "hello"); |
Contributor
There was a problem hiding this comment.
Is this usage not common in SQL?
| return null; | ||
| } | ||
| if (pos == Integer.MIN_VALUE) { | ||
| return null; |
Contributor
There was a problem hiding this comment.
Are the String and BinaryString versions inconsistent?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
fix: #758
How was this PR tested?