Skip to content

style: Integrate maven spotless plugin into project#757

Open
SYaoJun wants to merge 1 commit intoapache:masterfrom
SYaoJun:0303_spotless
Open

style: Integrate maven spotless plugin into project#757
SYaoJun wants to merge 1 commit intoapache:masterfrom
SYaoJun:0303_spotless

Conversation

@SYaoJun
Copy link
Contributor

@SYaoJun SYaoJun commented Mar 3, 2026

What changes were proposed in this pull request?

fix: #663

add spotless to pom.xml, run mvn spotless:apply automatically formatting the code.

How was this PR tested?

  • Tests have Added for the changes
  • Production environment verified

All tests have passed in local.

@SYaoJun SYaoJun changed the title style: normalize indentation and clean up empty interfaces style: Integrate maven spotless plugin and clean up empty interfaces Mar 3, 2026
@SYaoJun
Copy link
Contributor Author

SYaoJun commented Mar 4, 2026

This PR will change lots of files, do you have any suggestions? @Leomrlin

@SYaoJun
Copy link
Contributor Author

SYaoJun commented Mar 4, 2026

I have reverted the full formatting of all Java files. As an initial step, it would be better to integrate Spotless into the project first, and then address the style issues incrementally.

@SYaoJun SYaoJun changed the title style: Integrate maven spotless plugin and clean up empty interfaces style: Integrate maven spotless plugin into project Mar 4, 2026
@Leomrlin
Copy link
Contributor

Leomrlin commented Mar 5, 2026

I have reverted the full formatting of all Java files. As an initial step, it would be better to integrate Spotless into the project first, and then address the style issues incrementally.

Good catch! This is a legit issue, but Spotless formatting would massively break historical code (think git blame nightmares 😅).
Let's not merge this yet – please send a DISCUSS thread to dev@geaflow.apache.org first so PMC + community can weigh in.

We’ll sort out a phased plan (new files only → gradual cleanup) together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: Integrate maven spotless plugin.

2 participants