Skip to content

Feat job name config#570

Merged
xintongsong merged 5 commits intoapache:mainfrom
qingfei1994:feat-job-name-config
Apr 2, 2026
Merged

Feat job name config#570
xintongsong merged 5 commits intoapache:mainfrom
qingfei1994:feat-job-name-config

Conversation

@qingfei1994
Copy link
Copy Markdown
Contributor

@qingfei1994 qingfei1994 commented Mar 13, 2026 •
edited
Loading

Linked issue: #560

Purpose of change

Users can customize Job Name of Flink Agents.

Tests

UnitTest

API

Yes

Documentation

  • doc-needed
  • doc-not-needed
  • doc-included

@github-actions github-actions bot added priority/major Default priority of the PR or issue. fixVersion/0.3.0 The feature or bug should be implemented/fixed in the 0.3.0 version. doc-label-missing The Bot applies this label either because none or multiple labels were provided. labels Mar 13, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 13, 2026

@qingfei1994 Please add the following content to your PR description and select a checkbox:

- [ ] `doc-needed` 
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-included`

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing The Bot applies this label either because none or multiple labels were provided. labels Mar 13, 2026
wenjin272
wenjin272 reviewed Mar 19, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@wenjin272 wenjin272 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @qingfei1994, thanks for you work. The python part looks good to me, but the java part seems not complete.

api/src/main/java/org/apache/flink/agents/api/AgentsExecutionEnvironment.java Outdated
* @param jobName The name for the Flink job.
*/
public void execute(String jobName) throws Exception {
execute();
Copy link
Copy Markdown
Collaborator

@wenjin272 wenjin272 Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The job name is not passed to the underlying Flink execution environment.

Copy link
Copy Markdown
Contributor Author

@qingfei1994 qingfei1994 Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My first thought is to providing an optional execute with jobName method for other execution environment like LocalExecutionEnvironment which doesn't support executing with jobName, but since then I think I would just provide an abstract method here.

@wenjin272
Copy link
Copy Markdown
Collaborator

wenjin272 commented Mar 24, 2026

The logic code looks good to me. Could you add test for the java api like what you do in python?

@qingfei1994
Copy link
Copy Markdown
Contributor Author

qingfei1994 commented Mar 30, 2026

The logic code looks good to me. Could you add test for the java api like what you do in python?

Hi @wenjin272 I've added test for java api, please review

xintongsong
xintongsong approved these changes Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@xintongsong xintongsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this, @qingfei1994 and @wenjin272 . LGTM. Merging.

@xintongsong xintongsong merged commit 09f5f82 into apache:main Apr 2, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xintongsong xintongsong xintongsong approved these changes

+1 more reviewer

@wenjin272 wenjin272 wenjin272 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc-not-needed Your PR changes do not impact docs fixVersion/0.3.0 The feature or bug should be implemented/fixed in the 0.3.0 version. priority/major Default priority of the PR or issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qingfei1994 @wenjin272 @xintongsong