Skip to content

fix: reject edge cases #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
proost wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: reject edge cases #726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1621a61
fix: reject weight edge cases
proost Feb 16, 2026
dc8c194
Merge branch 'main' of https://github.com/apache/datasketches-java in…
proost Feb 16, 2026
26331b6
refactor: change error message
proost Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/org/apache/datasketches/sampling/VarOptItemsSketch.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -827,8 +827,8 @@ void update(final T item, final double weight, final boolean mark) {
if (item == null) {
return;
}
if (weight <= 0.0) {
throw new SketchesArgumentException("Item weights must be strictly positive: "
if (weight <= 0.0 || Double.isNaN(weight) || Double.isInfinite(weight)) {
throw new SketchesArgumentException("Item weights must be strictly positive and finite number: "
+ weight + ", for item " + item.toString());
}
++n_;
Expand Down
12 changes: 12 additions & 0 deletions src/test/java/org/apache/datasketches/sampling/VarOptItemsSketchTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,18 @@ public void checkInvalidWeight() {
vis.update("invalidWeight", -1.0); // should fail
}

@Test(expectedExceptions = SketchesArgumentException.class)
public void checkNaNWeight() {
final VarOptItemsSketch<String> vis = VarOptItemsSketch.newInstance(5);
vis.update("invalidWeight", Double.NaN);
}

@Test(expectedExceptions = SketchesArgumentException.class)
public void checkInfiniteWeight() {
final VarOptItemsSketch<String> vis = VarOptItemsSketch.newInstance(5);
vis.update("invalidWeight", Double.POSITIVE_INFINITY);
}

@Test
public void checkCorruptSerializedWeight() {
final VarOptItemsSketch<String> vis = VarOptItemsSketch.newInstance(24);
Expand Down
Loading