Skip to content

Conversation

@milenkovicm
Copy link
Contributor

Which issue does this PR close?

  • Closes #.

Rationale for this change

This is WIP which exposes datafusion query planner as FFI interface,
I hope to split this PR into two separate once implementation is nailed

What changes are included in this PR?

  • query planner moved to different module and interface changed (this will be subject of separate PR, once query planner part gets green light) there is question at which point Session should be downcast to SessionState. There are two approaches, non of which i particularly like
  • FFI query planner implementation

There are few open questions

  • is ffi planner module correct
  • can we expose FFI_SessionRef as public

Are these changes tested?

There is one test, integration test to follow if this makes sese

Are there any user-facing changes?

yes query planner is moved to different module and signature changed

@milenkovicm milenkovicm requested a review from timsaucer February 9, 2026 21:53
@github-actions github-actions bot added core Core DataFusion crate execution Related to the execution crate ffi Changes to the ffi crate labels Feb 9, 2026
@milenkovicm
Copy link
Contributor Author

it would be great if you could have a look @timsaucer, ffi/ part is important

@milenkovicm milenkovicm force-pushed the poc_ffi_query_planner branch from 965383c to 62cf3d8 Compare February 9, 2026 22:01
@timsaucer
Copy link
Member

Looking good! Instead of adding a lot of comments I put up this PR targeting your branch with some recommendations:

milenkovicm#1

@milenkovicm
Copy link
Contributor Author

thanks @timsaucer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate execution Related to the execution crate ffi Changes to the ffi crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants