fix: enable native_datafusion Spark SQL tests previously ignored in #3315#3696
Open
andygrove wants to merge 1 commit intoapache:mainfrom
Open
fix: enable native_datafusion Spark SQL tests previously ignored in #3315#3696andygrove wants to merge 1 commit intoapache:mainfrom
andygrove wants to merge 1 commit intoapache:mainfrom
Conversation
…pache#3315 Add numOutputRows metric alias to CometNativeScanExec so Spark's streaming ProgressReporter can find input row counts. Remove IgnoreCometNativeDataFusion tags from three Spark SQL tests that now pass with native_datafusion scan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3315.
Rationale for this change
Three Spark SQL tests were ignored for
native_datafusionscan mode due to plan structure differences. The root cause for the streaming tests was thatCometNativeScanExecdid not expose anumOutputRowsmetric, which Spark's streamingProgressReporteruses to count input rows.What changes are included in this PR?
CometNativeScanExec: AddnumOutputRowsas an alias for theoutput_rowsnative metric. Both keys reference the sameSQLMetricinstance, so when native code updatesoutput_rows, Spark's streaming framework sees the correct value vianumOutputRows.dev/diffs/3.5.8.diff: RemoveIgnoreCometNativeDataFusiontags from three tests:FileDataSourceV2FallBackSuite: "Fallback Parquet V2 to V1" (assertion already handlesCometNativeScanExec)StreamingQuerySuite: "SPARK-41198: input row calculation with CTE"StreamingQuerySuite: "SPARK-41199: input row calculation with mixed-up of DSv1 and DSv2 streaming sources"How are these changes tested?
All three tests verified locally with
COMET_PARQUET_SCAN_IMPL=native_datafusionagainst Spark 3.5.8 with the updated diff applied.