Skip to content

Conversation

@sakthivelmanii
Copy link

Please add a meaningful description for your change here


  1. Upgrade the Spanner to the latest version
  2. Remove the hardcoded Spanner BOM
  3. Use Spanner from libraries-bom

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @sakthivelmanii, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on modernizing and simplifying the dependency management for Google Cloud Spanner within the project. By upgrading Spanner to its latest version and integrating its versioning directly into the google_cloud_platform_libraries_bom, the change removes redundant hardcoded BOMs and exclusion rules. This consolidation improves consistency, reduces maintenance overhead, and ensures that Spanner-related modules are always aligned with the broader Google Cloud platform library versions.

Highlights

  • Spanner Version Upgrade: The Google Cloud Spanner library has been upgraded to its latest version, ensuring the project benefits from the most recent features and bug fixes.
  • Dependency Management Simplification: Hardcoded Spanner Bill of Materials (BOM) version definitions have been removed, streamlining dependency management.
  • Consolidated Spanner Dependencies: Spanner dependencies are now consistently managed through the google_cloud_platform_libraries_bom, eliminating previous exclusion rules and direct BOM references.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
    • Removed the explicit google_cloud_spanner_version variable definition.
    • Eliminated the google_cloud_spanner_bom and google_cloud_spanner_test entries from the library.java map, now relying on google_cloud_platform_libraries_bom for Spanner versioning.
  • sdks/java/bom/gcp/build.gradle
    • Removed the direct api platform(project.library.java.google_cloud_spanner_bom) dependency.
    • Removed the exclude block that prevented specific Spanner modules from being managed by google_cloud_platform_libraries_bom.
  • sdks/java/io/google-cloud-platform/build.gradle
    • Removed the exclude block for Spanner modules from the google_cloud_platform_libraries_bom enforced platform dependency.
    • Removed the implementation(enforcedPlatform(library.java.google_cloud_spanner_bom)) dependency.
    • Updated the testImplementation for google_cloud_spanner_test to a direct string literal "com.google.cloud:google-cloud-spanner::tests".
Activity
  • The pull request was created by sakthivelmanii.
  • The PR description includes a checklist for contributions and links to CI build statuses, but no human comments or reviews have been recorded yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, there's an extra character here

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2026

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@damccorm
Copy link
Contributor

damccorm commented Feb 9, 2026

This is still causing https://github.com/apache/beam/actions/runs/21839093811/job/63018211659?pr=37552 to fail with

SpannerChangeStreamOrderedWithinKeyGloballyIT > testOrderedWithinKey FAILED
    java.lang.AssertionError at SpannerChangeStreamOrderedWithinKeyGloballyIT.java:159
        Caused by: java.lang.AssertionError at MatcherAssert.java:18

So it seems the failure is caused by this piece

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants