Skip to content

ATLAS-5210: replace hbase-shaded-* libraries with hbase-shaded-*-hadoop3 libraries#530

Open
mneethiraj wants to merge 5 commits intoapache:masterfrom
mneethiraj:ATLAS-5210
Open

ATLAS-5210: replace hbase-shaded-* libraries with hbase-shaded-*-hadoop3 libraries#530
mneethiraj wants to merge 5 commits intoapache:masterfrom
mneethiraj:ATLAS-5210

Conversation

@mneethiraj
Copy link
Contributor

@mneethiraj mneethiraj commented Feb 17, 2026

What changes were proposed in this pull request?

  • replaced hbase-shaded-mapreduce with hbase-shaded-mapreduce-hadoop3
  • replaced hbase-shaded-client with hbase-shaded-client-hadoop3
  • hbase-shaded-client-hadoop3 has 2 bad entries in META-INF/services, javax.ws.rs.ext.MessageBodyReader and javax.ws.rs.ext.MessageBodyWriter, which caused ServiceFinder to fail in looking for a non existing class. Hence hbase-shaded-client-fixed module was introduced to unpack the library and repack it by excluding these bad entries

How was this patch tested?

  • verified that build completes successfully
  • verfied that Atlas processes notifications in ATLAS_HOOK topics successfully
  • verified quick_start.py completes successfully

…th hbase-shaded-client-hadoop3 and hbase-shaded-mapreduce-hadoop3
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades HBase shaded libraries from non-Hadoop3 variants to Hadoop3-specific variants to improve Hadoop 3 compatibility. However, the PR description explicitly states that critical issues remain unresolved, including application startup failures and UI unavailability.

Changes:

  • Updated hbase-shaded-client and hbase-shaded-mapreduce dependencies to use -hadoop3 suffixed versions in repository/pom.xml and graphdb/janus/pom.xml
  • Added hadoop-distcp dependency and excluded it from hbase-shaded-mapreduce to resolve dependency conflicts
  • Updated imports from commons-configuration to commons-configuration2 (shaded from HBase) in AtlasDebugMetricsSink classes

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
repository/pom.xml Updated hbase-shaded-client version to include -hadoop3 suffix
graphdb/janus/pom.xml Updated both hbase-shaded-client and hbase-shaded-mapreduce to -hadoop3 versions, added hadoop-distcp dependency and excluded it from hbase-shaded-mapreduce
webapp/src/main/java/org/apache/atlas/web/service/AtlasDebugMetricsSink.java Changed import from commons-configuration to commons-configuration2 (shaded from HBase)
webapp/src/test/java/org/apache/atlas/web/service/AtlasDebugMetricsSinkTest.java Changed import from commons-configuration to commons-configuration2 (shaded from HBase)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@mandarambawane mandarambawane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants