ATLAS-5210: replace hbase-shaded-* libraries with hbase-shaded-*-hadoop3 libraries#530
ATLAS-5210: replace hbase-shaded-* libraries with hbase-shaded-*-hadoop3 libraries#530mneethiraj wants to merge 5 commits intoapache:masterfrom
Conversation
…th hbase-shaded-client-hadoop3 and hbase-shaded-mapreduce-hadoop3
There was a problem hiding this comment.
Pull request overview
This PR upgrades HBase shaded libraries from non-Hadoop3 variants to Hadoop3-specific variants to improve Hadoop 3 compatibility. However, the PR description explicitly states that critical issues remain unresolved, including application startup failures and UI unavailability.
Changes:
- Updated hbase-shaded-client and hbase-shaded-mapreduce dependencies to use -hadoop3 suffixed versions in repository/pom.xml and graphdb/janus/pom.xml
- Added hadoop-distcp dependency and excluded it from hbase-shaded-mapreduce to resolve dependency conflicts
- Updated imports from commons-configuration to commons-configuration2 (shaded from HBase) in AtlasDebugMetricsSink classes
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| repository/pom.xml | Updated hbase-shaded-client version to include -hadoop3 suffix |
| graphdb/janus/pom.xml | Updated both hbase-shaded-client and hbase-shaded-mapreduce to -hadoop3 versions, added hadoop-distcp dependency and excluded it from hbase-shaded-mapreduce |
| webapp/src/main/java/org/apache/atlas/web/service/AtlasDebugMetricsSink.java | Changed import from commons-configuration to commons-configuration2 (shaded from HBase) |
| webapp/src/test/java/org/apache/atlas/web/service/AtlasDebugMetricsSinkTest.java | Changed import from commons-configuration to commons-configuration2 (shaded from HBase) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
webapp/src/main/java/org/apache/atlas/web/service/AtlasDebugMetricsSink.java
Show resolved
Hide resolved
webapp/src/test/java/org/apache/atlas/web/service/AtlasDebugMetricsSinkTest.java
Show resolved
Hide resolved
…ies in hbase-shaded-client library
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mandarambawane
left a comment
There was a problem hiding this comment.
Looks good to me.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
What changes were proposed in this pull request?
How was this patch tested?