[AMORO-4044][amoro-format-iceberg] Fix SLF4J log format placeholder in TableEntriesScan#4102
Open
lintingbin wants to merge 2 commits intoapache:masterfrom
Open
Conversation
Replace printf-style `%S` with SLF4J-style `{}` in LOG calls within
buildDataFile() and buildDeleteFile(). The `%S` placeholder is not
recognized by SLF4J, so the filePath parameter was never substituted
into the log message. Also change log level from info to warn since
missing specId is an abnormal condition worth attention.
Signed-off-by: Darcy <lintingbin@lilith.com>
klion26
approved these changes
Mar 2, 2026
Member
klion26
left a comment
klion26
left a comment
There was a problem hiding this comment.
@lintingbin Thanks for the contribution, LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
In
TableEntriesScan, bothbuildDataFile()andbuildDeleteFile()useLOG.info("No specId found for the current fileRecord[%S]", filePath)to log a warning when no specId is found. However, SLF4J uses{}as the parameter placeholder, not%S(which is printf-style). As a result, thefilePathvariable is never substituted into the log message, making the log output useless for debugging.This was discovered while reviewing PR #4085.
Brief change log
%Swith{}in twoLOGcalls withinbuildDataFile()andbuildDeleteFile()infotowarnsince a missing specId is an abnormal condition that deserves attentionHow was this patch tested?
Documentation
no
not applicable