Fixes to MultipleManagerStartupWaitIT#6214
Merged
dlmarion merged 1 commit intoapache:mainfrom Mar 13, 2026
Merged
Conversation
keith-turner
approved these changes
Mar 12, 2026
| // Start the 2nd Manager | ||
| getCluster().getConfig().getClusterServerConfiguration().setNumManagers(2); | ||
| getCluster().start(); | ||
| // Don't call Cluster.start, it's synchronized and the thread |
Contributor
There was a problem hiding this comment.
This comment helped me understand why setup is called in a background thread. Would setUp() block forever if min managers was set to 2?
Contributor
Author
There was a problem hiding this comment.
min manager is set to 2 in configure(), but we started mini accumulo with the default number of managers (1). So the thread that is starting mini is stuck in verifyUp() waiting for the one manager that we started to grab the primary lock. However, the manager hasn't gotten that far in Manager.run because it's waiting for 2 managers.
Would setUp() block forever if min managers was set to 2?
It is set to 2 at line 46 above, and will block for 5m according to the property set at line 47.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.