Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes issue #6151
Added a new Enum LOCKED to
TableStateandInitialTableStateand deprecated OFFLINE. I have so far only added in the new usage of LOCKED into the basic functionality, I still need to update all the test for the new state. But I figured to make the draft now so to get feedback on its direction. I have also left in the usage of OFFLINE state to not break anything just yet, but have had to add in a couple supresswarnings to ensure it builds. I did not do anything with upgrade behavior to support transition from OFFLINE to LOCKED and I also left OfflineIterator alone for the most part, but I'm not entirely sure how I should handle them going forward.The new LOCKED state blocks all operations, except delete, on a table. It does allow for table export (to replace OFFLINE) and dose NOT unhost tablets (stay in their current hosting state). The thought was that LOCKED is a "frozen" state and not a "shutdown" state. If you need tablets to be unhosted, you can use
TabletAvailabilitysettings in combination withlock(). The new state slow is as follows:NEW -> (ONLINE | OFFLINE | LOCKED) <--> DELETING