Added Multiple Manager support to Mini Accumulo#6208
Merged
dlmarion merged 5 commits intoapache:mainfrom Mar 12, 2026
Merged
Conversation
test/src/main/java/org/apache/accumulo/test/MultipleManagerIT.java
Outdated
Show resolved
Hide resolved
keith-turner
approved these changes
Mar 12, 2026
Comment on lines
+592
to
+593
| return managerProcesses.size() == 0 ? Set.of() | ||
| : Set.copyOf(new HashSet<>(managerProcesses)); |
Contributor
There was a problem hiding this comment.
Seems like this should be syncronized. Also do not need to put in a hashset first.
Suggested change
| return managerProcesses.size() == 0 ? Set.of() | |
| : Set.copyOf(new HashSet<>(managerProcesses)); | |
| synchronized(managerProcesses){ | |
| return managerProcesses.isEmpty() ? Set.of() | |
| : Set.copyOf(managerProcesses); | |
| } |
| if (control.managerProcess != null) { | ||
| result.put(type, references(control.managerProcess)); | ||
| } | ||
| result.put(type, references(control.managerProcesses.stream().collect(Collectors.toList()) |
Contributor
There was a problem hiding this comment.
This feels like it should syncronize, however that would not follow the pattern of the rest of this code. It seems like all the other code in this class does not sync for the other server types. Seems like a general existing problem, not sure if making one different is worth it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.