Update Galaxia names and fix examples#1223
Merged
LourensVeen merged 1 commit intoamusecode:mainfrom Mar 12, 2026
Merged
Conversation
9faf94a to
3d61e03
Compare
3d61e03 to
e4a731f
Compare
Member
Author
|
I originally updated the examples that use Galaxia too, but I've removed that because #1227 makes some big changes to the examples, and will be easier to merge on top of this then. We'll update the examples that use Galaxia there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates galaxia to use the name
Galaxiaeverywhere, rather thanBarAndSpirals3DorBarandspirals3d. The latter two are still importable fromamuse.community.galaxiaandamuse.community.galaxia.interfacefor backwards compatibily. (But not fromamuse_galaxia.)This also updates the galaxia examples in
examples/examples_galaxiaandexamples/textbook, and applies a few other small fixes to make them work, as it seems like they broke somewhen between 2018 and now. We should set up a CI that runs the examples...Fixes #1194.