Skip to content

fix: rewrite cve-fixer startupPrompt as agent directive#93

Merged
jwm4 merged 2 commits intoambient-code:mainfrom
jwm4:fix/cve-fixer-startup-prompt
Mar 30, 2026
Merged

fix: rewrite cve-fixer startupPrompt as agent directive#93
jwm4 merged 2 commits intoambient-code:mainfrom
jwm4:fix/cve-fixer-startup-prompt

Conversation

@jwm4
Copy link
Copy Markdown
Contributor

@jwm4 jwm4 commented Mar 29, 2026

Summary

  • Rewrites the cve-fixer startupPrompt from a canned greeting into an agent directive
  • startupPrompt is sent TO the agent as a hidden user message (role: "user", hidden: true), not displayed to the user — so it should instruct the agent how to greet, not be a greeting itself

Changes

  • workflows/cve-fixer/.ambient/ambient.json: Rewrite startupPrompt as a directive

Test plan

  • Load the cve-fixer workflow in ACP and verify the agent greets naturally
  • Verify /cve.find and /cve.fix commands still work as expected

Custom Workflow Testing

Field Value
URL https://github.com/jwm4/workflows.git
Branch fix/cve-fixer-startup-prompt
Path workflows/cve-fixer

🤖 Generated with Claude Code under the supervision of Bill Murdock.

startupPrompt is sent TO the agent as a hidden user message, not
displayed to the user. Rewrite it as an instruction telling the agent
how to greet the user rather than a canned greeting.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 29, 2026

Walkthrough

The startup prompt message in the CVE Remediation workflow configuration was updated to provide clearer instructions for users, introducing the assistant's purpose, referencing available commands (/cve.find and /cve.fix), and directing new users to relevant documentation.

Changes

Cohort / File(s) Summary
CVE Fixer Workflow Configuration
workflows/cve-fixer/.ambient/ambient.json
Updated startupPrompt field with revised welcome message that describes the assistant's functionality, explicitly lists available commands, directs users to onboarding documentation, and prompts engagement.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: rewriting the startupPrompt as an agent directive in the cve-fixer workflow.
Description check ✅ Passed The description is directly related to the changeset, explaining the rationale for the change and providing clear test steps.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Take upstream's updated systemPrompt (adds component mapping note and
team onboarding reference) and our startupPrompt rewrite (directive
style). Also incorporated the onboarding reference into the directive.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jwm4 jwm4 marked this pull request as ready for review March 30, 2026 12:34
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@workflows/cve-fixer/.ambient/ambient.json`:
- Line 5: The startupPrompt value should be made more readable and slightly
clearer: update the "startupPrompt" string to use explicit bullet-like line
breaks for the command list and change "If this is their first time" to "If this
is their first time using this workflow"; modify the startupPrompt entry (the
"startupPrompt" JSON property) to include newline-separated sentences and a
short bulleted list for the commands (/cve.find, /cve.fix) and the clarified
phrase so the agent can parse and present instructions more clearly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: b56f8440-a8e5-421f-b7ab-730446b6ed65

📥 Commits

Reviewing files that changed from the base of the PR and between 4bfd9e5 and da8f20d.

📒 Files selected for processing (1)
  • workflows/cve-fixer/.ambient/ambient.json

"description": "Automate remediation of CVE issues reported by ProdSec team in Jira by creating pull requests with dependency updates and patches",
"systemPrompt": "You are a CVE remediation assistant for the Ambient Code Platform. Your role is to help users remediate CVE issues that have been reported by the ProdSec team in Jira by automatically creating pull requests with fixes.\n\nKEY RESPONSIBILITIES:\n- Guide users through the CVE remediation workflow for Jira-tracked vulnerabilities\n- Execute slash commands to perform specific security tasks\n- Find CVE issues opened by ProdSec team in Jira\n- Implement secure fixes that resolve vulnerabilities without breaking functionality\n- Create pull requests with dependency updates, patches, and comprehensive test results\n\nWORKFLOW METHODOLOGY:\n1. FIND - Find CVEs already reported in Jira for a component\n2. FIX - Implement remediation strategies (dependency updates, patches, code changes, PR creation)\n\nAVAILABLE COMMANDS:\n/cve.find - Find CVEs reported in Jira for a specific component\n/cve.fix - Implement fixes for discovered CVEs and create pull requests\n\nOUTPUT LOCATIONS:\n- Create all Jira CVE findings in: artifacts/cve-fixer/find/\n- Create all fix implementations in: artifacts/cve-fixer/fixes/\n\nNote: Commands will guide you through required setup steps on first use. If the user's component is not in component-repository-mappings.json, direct them to the \"Team Onboarding\" section in README.md.",
"startupPrompt": "Welcome! I'm your CVE Remediation assistant.\n\n🎯 WHAT I DO:\nI help you remediate CVE issues reported by the ProdSec team in Jira by automatically creating pull requests with dependency updates, patches, and code changes.\n\n📋 WORKFLOW PHASES:\n1. **Find** - Discover CVE issues opened by ProdSec in Jira for a component\n2. **Fix** - Implement secure remediations and create pull requests\n\n🚀 AVAILABLE COMMANDS:\n/cve.find - Find CVE issues reported by ProdSec in Jira\n/cve.fix - Implement security fixes and create PRs\n\n💡 GETTING STARTED:\nRun /cve.find to discover CVE issues from ProdSec in Jira for a specific component, then use /cve.fix to automatically remediate them with pull requests.\n\nFirst time? See README.md → \"Team Onboarding\" for setup requirements.\n\nWhat would you like to accomplish today?",
"startupPrompt": "Greet the user and introduce yourself as a CVE remediation assistant. Explain that you help remediate CVE issues reported by ProdSec in Jira by creating pull requests. Mention the two commands: /cve.find to discover CVEs and /cve.fix to implement fixes. If this is their first time, point them to README.md Team Onboarding for setup. Suggest starting with /cve.find and ask what they'd like to work on.",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

LGTM! Successfully converted to an agent directive.

The startupPrompt now correctly instructs the agent how to greet rather than being a direct greeting, which aligns perfectly with the PR objective. The content is comprehensive, references the correct commands (/cve.find, /cve.fix), and points to the appropriate onboarding documentation.

Optional suggestions for enhanced readability:

  1. Consider breaking the directive into bullet points for easier parsing by the agent:

    "startupPrompt": "Greet the user and introduce yourself as a CVE remediation assistant. Explain that you help remediate CVE issues reported by ProdSec in Jira by creating pull requests.\n\nMention these commands:\n- /cve.find to discover CVEs\n- /cve.fix to implement fixes\n\nFor first-time users, point them to README.md Team Onboarding for setup. Suggest starting with /cve.find and ask what they'd like to work on."
  2. Minor clarity improvement: "If this is their first time" could be "If this is their first time using this workflow" for specificity.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@workflows/cve-fixer/.ambient/ambient.json` at line 5, The startupPrompt value
should be made more readable and slightly clearer: update the "startupPrompt"
string to use explicit bullet-like line breaks for the command list and change
"If this is their first time" to "If this is their first time using this
workflow"; modify the startupPrompt entry (the "startupPrompt" JSON property) to
include newline-separated sentences and a short bulleted list for the commands
(/cve.find, /cve.fix) and the clarified phrase so the agent can parse and
present instructions more clearly.

@vmrh21
Copy link
Copy Markdown
Contributor

vmrh21 commented Mar 30, 2026

Lgtm!

@jwm4 jwm4 merged commit 02fdd05 into ambient-code:main Mar 30, 2026
2 checks passed
@jwm4 jwm4 deleted the fix/cve-fixer-startup-prompt branch March 30, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants