Skip to content

Add dev-team workflow#91

Open
jwm4 wants to merge 2 commits intoambient-code:mainfrom
jwm4:feature/add-dev-team-workflow
Open

Add dev-team workflow#91
jwm4 wants to merge 2 commits intoambient-code:mainfrom
jwm4:feature/add-dev-team-workflow

Conversation

@jwm4
Copy link
Copy Markdown
Contributor

@jwm4 jwm4 commented Mar 29, 2026

Summary

  • Adds a new dev-team workflow that acts as a team lead, dynamically assembling 2-4 specialized AI agents to handle development tasks
  • Supports code implementation, PR reviews, doc reviews, technical strategy, and communications
  • Built-in quality gates: every task gets at least one executor and one checker
  • Uses the /dev-team [task description] skill as its single entry point. That skill comes from Ben Browning's Claude configuration and is used with his permission.

Test plan

  • Load as custom workflow in ACP:
    • URL: https://github.com/jwm4/workflows.git
    • Branch: feature/add-dev-team-workflow
    • Path: workflows/dev-team
  • Verify startup greeting is generated by the agent (not a canned message)
  • Test /dev-team skill with a simple code task
  • Test /dev-team skill with a PR review task
  • Verify team assembly (2-4 agents spawned)
  • Verify quality gate (checker agent reviews output)

🤖 Generated with Claude Code

This comment comes from Claude Code under the supervision of Bill Murdock.

Add a new workflow that acts as a team lead, dynamically assembling
specialized AI agent teams (2-4 agents) to handle code implementation,
PR reviews, doc reviews, strategy, and communications with built-in
quality gates.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 29, 2026

Walkthrough

This PR introduces a new "Dev Team" workflow system that orchestrates multi-agent AI workflows for development tasks. It includes configuration metadata, skill definitions for task orchestration and pull request creation, and comprehensive documentation describing the system's architecture and operation.

Changes

Cohort / File(s) Summary
Workflow Configuration
workflows/dev-team/.ambient/ambient.json
Added AI agent metadata and prompting configuration defining the Dev Team agent's system behavior, including role descriptions, workflow methodology, and startup instructions.
Skill Definitions
workflows/dev-team/.claude/skills/dev-team/SKILL.md, workflows/dev-team/.claude/skills/pr/SKILL.md
Added two skill workflows: (1) dev-team orchestrates multi-agent task execution across six phases—classification, team design, quality standards application, user confirmation, execution with revision cycles, and result delivery; (2) pr defines a comprehensive pull request creation workflow with preflight checks, authentication branching, fork-based workflows, branch management, and detailed error handling with fallback approaches.
Documentation
workflows/dev-team/README.md
Added overview documentation describing the dynamic team assembly process, supported skills, output artifacts, quality standards, and customization points for the Dev Team workflow.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add dev-team workflow' directly and clearly describes the main change: introduction of a new dev-team workflow system.
Description check ✅ Passed The description comprehensively explains the dev-team workflow's purpose, capabilities, quality gates, and entry point, directly relating to the changeset additions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy the PR creation skill from the bugfix workflow, adapted for
general use. This handles fork workflows, authentication, and remote
setup systematically — addressing failures when the dev-team tried
ad-hoc PR creation on the Ambient platform.

The dev-team skill now directs users to /pr after code tasks complete
instead of attempting its own PR creation logic.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jwm4 jwm4 marked this pull request as ready for review March 29, 2026 19:58
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@workflows/dev-team/.claude/skills/pr/SKILL.md`:
- Around line 469-476: Add a concrete URL-encoding example for the compare URL
fallback by showing how to encode PR_TITLE and PR_BODY into ENCODED_TITLE and
ENCODED_BODY and then build COMPARE_URL; specifically, add a shell-based example
that uses python3's urllib.parse.quote (or an equivalent URL-encoding command)
to produce ENCODED_TITLE and ENCODED_BODY from PR_TITLE and PR_BODY and then
demonstrates constructing COMPARE_URL with
?expand=1&title=${ENCODED_TITLE}&body=${ENCODED_BODY} so special characters are
safely encoded and the compare URL won’t break.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 70ae6da8-edb0-4d73-995c-87911894e4cd

📥 Commits

Reviewing files that changed from the base of the PR and between 1bd9d6e and 6e6bf76.

📒 Files selected for processing (4)
  • workflows/dev-team/.ambient/ambient.json
  • workflows/dev-team/.claude/skills/dev-team/SKILL.md
  • workflows/dev-team/.claude/skills/pr/SKILL.md
  • workflows/dev-team/README.md

Comment on lines +469 to +476
```text
https://github.com/UPSTREAM_OWNER/REPO/compare/main...FORK_OWNER:BRANCH_NAME?expand=1&title=URL_ENCODED_TITLE&body=URL_ENCODED_BODY
```

URL-encode the title and body. If the encoded URL would exceed ~8KB
(browser limit), omit the `body` parameter — the commit message body
from Step 6 will still auto-fill the description for single-commit PRs.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Provide URL encoding implementation for compare URL fallback.

The instructions tell the agent to "URL-encode the title and body" but provide no actual encoding mechanism. Without proper URL encoding, special characters (spaces, quotes, special symbols) in PR titles or descriptions will break the compare URL. This fallback path is explicitly noted as "common and expected" for GitHub App bots (line 463), making it a frequently-used code path.

🔧 Suggested fix: Add shell-based URL encoding example

After line 471, add a concrete encoding example:

    ```text
    https://github.com/UPSTREAM_OWNER/REPO/compare/main...FORK_OWNER:BRANCH_NAME?expand=1&title=URL_ENCODED_TITLE&body=URL_ENCODED_BODY
    ```
+
+   **URL-encode using Python:**
+   ```bash
+   # Encode title and body for the URL
+   ENCODED_TITLE=$(python3 -c "import urllib.parse; print(urllib.parse.quote('''$PR_TITLE'''))")
+   ENCODED_BODY=$(python3 -c "import urllib.parse; print(urllib.parse.quote('''$PR_BODY'''))")
+   
+   # Construct the compare URL
+   COMPARE_URL="https://github.com/UPSTREAM_OWNER/REPO/compare/main...FORK_OWNER:BRANCH_NAME?expand=1&title=${ENCODED_TITLE}&body=${ENCODED_BODY}"
+   ```
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@workflows/dev-team/.claude/skills/pr/SKILL.md` around lines 469 - 476, Add a
concrete URL-encoding example for the compare URL fallback by showing how to
encode PR_TITLE and PR_BODY into ENCODED_TITLE and ENCODED_BODY and then build
COMPARE_URL; specifically, add a shell-based example that uses python3's
urllib.parse.quote (or an equivalent URL-encoding command) to produce
ENCODED_TITLE and ENCODED_BODY from PR_TITLE and PR_BODY and then demonstrates
constructing COMPARE_URL with
?expand=1&title=${ENCODED_TITLE}&body=${ENCODED_BODY} so special characters are
safely encoded and the compare URL won’t break.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipping this for now. The PR skill here is a copy from the bugfix workflow, which also doesn't include this encoding example and works fine — the agent running the skill is an LLM that knows how to URL-encode when told to.

The PR skill is also being overhauled in #90, so we'll need to reconcile the diverging versions at some point. We'll address improvements to the PR skill holistically there rather than patching individual copies.

This comment was posted by Claude Code under the supervision of Bill Murdock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant