Skip to content

Fix scrum_team_board test for acme data#11

Open
jeremyeder wants to merge 1 commit intomainfrom
fix-scrum-team-board-test
Open

Fix scrum_team_board test for acme data#11
jeremyeder wants to merge 1 commit intomainfrom
fix-scrum-team-board-test

Conversation

@jeremyeder
Copy link
Copy Markdown
Contributor

Summary

  • scrum_team_board is conditionally populated from an XLSX tab that acme example data doesn't include
  • Test now skips this check only when acme data is the source (data/acme-*.xlsx present)
  • Non-acme deployments still fail if the table is unexpectedly empty

Test plan

  • bash scripts/test.sh passes locally with acme data (SKIP)
  • CI passes

🤖 Generated with Claude Code

The scrum_team_board table is conditionally populated from a
"Scrum Team Boards" XLSX tab. The acme example data doesn't
include this tab, so skip the check only when acme data is the
source. Non-acme deployments still fail if the table is empty.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: b282c148-e610-43a6-8eb4-255cc71453ed

📥 Commits

Reviewing files that changed from the base of the PR and between 4717397 and 7b2eb9b.

📒 Files selected for processing (1)
  • scripts/test.sh

Walkthrough

Updated row count validation checks in the test script to compute table row counts via captured command results rather than relying on a helper function exit status. Added explicit Bash branching to report PASS, FAIL, or SKIP outcomes. Introduced conditional skip logic for the scrum_team_board table when expected data files are absent.

Changes

Cohort / File(s) Summary
Test validation refactor
scripts/test.sh
Modified "Key tables populated" checks to capture row counts using uv run python3 -c ... and added explicit PASS/FAIL/SKIP branching. Added skip condition for scrum_team_board when data/acme-*.xlsx files are missing.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly describes the main change: fixing the scrum_team_board test to handle acme data, which is the core purpose of this pull request.
Description check ✅ Passed The description clearly explains why the test was changed (scrum_team_board is conditionally populated from an XLSX tab acme data lacks) and documents the new behavior and test plan.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-scrum-team-board-test

Comment @coderabbitai help to get the list of available commands and usage tips.

@jeremyeder jeremyeder mentioned this pull request Mar 26, 2026
3 tasks
@jeremyeder
Copy link
Copy Markdown
Contributor Author

@ambient why is the sky blue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant