Conversation
singiamtel
force-pushed
the
te172983
branch
2 times, most recently
from
3399496 to
cf98abb
Compare
ktf
reviewed
Jan 14, 2026
|
|
||
| [tool.setuptools.packages.find] | ||
| where = ["."] | ||
| exclude = ["yaml"] |
Member
There was a problem hiding this comment.
This is unrelated to the RPMs no? Please open a separate PR.
Collaborator
Author
There was a problem hiding this comment.
Using rpmbuild I get errors for unused packages inside the RPM, that's why I added it
Member
There was a problem hiding this comment.
Is the whole PR ready to be tested and merged? If yes, no need to change. If not, all I am saying this is a good cleanup in any case and we can separately merge it already now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This slims down the RPMs published and simplifies the build/publish process (currently in ali-bot)
The plan is to start publishing the last RPM of aliBuild automatically (but still decoupled from the CI checkers version), and keep several older versions (e.g. last 5) available for download. Now we auto publish for pypi and brew, but not RPMs
This way users can pin to a specific aliBuild version if needed. Currently we only keep the last one
The build-rpm.sh script currently only builds them. The logic is pretty simple so it can be adapted to using the git repo directly, and publishing to S3
Probably better to merge after Christmas