Sequence logging effects in S3Writer using flatTap and *>#4
Closed
Copilot wants to merge 2 commits intocopilot/build-etl-pipeline-scalafrom
Closed
Sequence logging effects in S3Writer using flatTap and *>#4Copilot wants to merge 2 commits intocopilot/build-etl-pipeline-scalafrom
Copilot wants to merge 2 commits intocopilot/build-etl-pipeline-scalafrom
Conversation
Merged
Use flatTap and *> operators to properly sequence logging effects instead of discarding them. This ensures logging is actually performed. Co-authored-by: akreit <64101884+akreit@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update to address feedback on cats logger implementation
Sequence logging effects in S3Writer using flatTap and *>
Dec 29, 2025
akreit
approved these changes
Dec 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logging statements in
S3Writerwere executed for side-effects but theirF[Unit]results were discarded, preventing the logs from actually being emitted.Changes
createS3Client: UseflatTapto sequence the logging effect after client constructionensureBucket: Refactor to use*>for proper effect sequencing across conditional branchesExample
Before:
After:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.