fix: revert ABI breaking addition of assignments in C++#239
fix: revert ABI breaking addition of assignments in C++#239
Conversation
04d5189 to
271c9cb
Compare
271c9cb to
894b828
Compare
894b828 to
a307107
Compare
SprGrf
left a comment
There was a problem hiding this comment.
Good for me. I would add the reason why are reverting in the changelog for transparency.
source/modulo_components/include/modulo_components/ComponentInterface.hpp
Outdated
Show resolved
Hide resolved
source/modulo_controllers/include/modulo_controllers/BaseControllerInterface.hpp
Outdated
Show resolved
Hide resolved
This reverts commit b8d7f0e.
a307107 to
f15a5dc
Compare
eeberhard
left a comment
There was a problem hiding this comment.
this PR will just fast forward the commits without squashing
I think it defeats the purpose of fastforwarding these changes if you've made any changes to the revert commits (the typos in Predicate, and the changelog). I would prefer to squash this, as is, into one revert commit which has the two revert messages in the commit body plus the additional changes made as another entry in the commit body.
Or else, if you want to fast-forward, keep the first two as pure revert commits and add a third chore commit that touches up the typos and changelog, but that means rewriting this branch again
Description
As described, this PR will just fast forward the commits without squashing
Review guidelines
Estimated Time of Review: 10 minutes
Checklist before merging:
Related issues
Blocked by: