CEXT-5230: Releasing aio app db cli commands#27
Conversation
Co-authored-by: Peter Dohogne <pdohogne@adobe.com>
Feat/cext 4859
feat:cext-4860 added standalone commands
CEXT-5659 updated readme with new region behavior
CEXT-5679: Add 'aus' to db region options
CEXT-5783: 'db org stats' command
feat: add Ims token for db commands
package.json
Outdated
| { | ||
| "name": "@adobe/aio-cli-plugin-app-storage", | ||
| "version": "1.2.0", | ||
| "version": "1.3.0", |
There was a problem hiding this comment.
Revert this, version change is an npm-publish-time change.
|
|
||
| # Commands | ||
| <!-- commands --> | ||
| ## State Storage Commands |
There was a problem hiding this comment.
Updating and is part of the release process (prepack). If you are adding any text/description make sure it is not in these sections or it will be overwritten. These sections are generated directly from the code.
There was a problem hiding this comment.
Will the generation work with the updated project directory structure separating state and storage commands?
There was a problem hiding this comment.
Do you want me to revert these changes, or can I leave them and let them be overwritten by the generation?
There was a problem hiding this comment.
doc generation should be fine, we can verify by running prepack and checking if it makes the same changes.
no need to revert, a new commit is fine, we typically squash with a detailed commit message.
| let packageJson | ||
| try { | ||
| // eslint-disable-next-line node/no-unsupported-features/es-syntax | ||
| const { readFile } = await import('fs/promises') |
There was a problem hiding this comment.
It is that way in main, we changed as little about the state commands as possible.
There was a problem hiding this comment.
In :main/BaseCommand the module being loaded has properties that get reset by the dynamic import. Here we are just using readFile which never changes, so single import at the top of the file would be fine.
We use fs-extra pretty much everywhere as it does promise|await|callback and has convenience methods (readJSON)
I think this is fine to leave in, not that big of a deal.
It should also probably be import('node:fs/promises') but this is all minor.
| let packageJson | ||
| try { | ||
| // eslint-disable-next-line node/no-unsupported-features/es-syntax | ||
| const { readFile } = await import('fs/promises') |
There was a problem hiding this comment.
In :main/BaseCommand the module being loaded has properties that get reset by the dynamic import. Here we are just using readFile which never changes, so single import at the top of the file would be fine.
We use fs-extra pretty much everywhere as it does promise|await|callback and has convenience methods (readJSON)
I think this is fine to leave in, not that big of a deal.
It should also probably be import('node:fs/promises') but this is all minor.
Description
Committing
aio app dbcommands to mainRelated Issue
CEXT-5230: Deploy CLI DB App to Staging
Motivation and Context
Release
aio app dbcommandsHow Has This Been Tested?
Unit and manual tests, see PRs #12 - #26
Screenshots (if appropriate):
Types of changes
Checklist: