Merged
Conversation
Migrate from direct `.assets_required` attribute access to using the new `get_required_assets()` helper function from the adcp library. Changes: - Update adcp dependency from >=2.18.0 to >=3.1.0 - Use get_required_assets() for filtering and iterating required assets - Update base.py to use .assets for building complete asset type maps - Simplify server.py by removing unused asset_group_id handling - Update all tests to use the new API Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
adcplibrary from v2.18.0 to v3.1.0.assets_requiredattribute access to using the newget_required_assets()helper functionbase.pyto use.assetsfor building complete asset type maps (intentional—type maps need all assets, not just required)server.pyby removing unusedasset_group_idhandling (no formats in codebase use repeatable groups)Test plan
🤖 Generated with Claude Code