feat!: Unify brand identity — delete brand-manifest.json, use brand refs#1113
Merged
feat!: Unify brand identity — delete brand-manifest.json, use brand refs#1113
Conversation
Add key concepts sections and callouts across brand documentation to address confusion between brand.json (the file) and brand manifest (the data structure). Closes #1110. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Revise "contains" language to be more precise about brand.json variants - Replace research_brand with public-facing terminology in resolution table - Add cross-links between resolution sources, registry, and brand manifest - Apply sentence case to all headers in brand-manifest.mdx - Update analogy to account for redirect and agent variants Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
brand.json's brand object is now the single canonical brand definition.
Task schemas reference brands by domain + brand_id instead of passing
inline manifests. Brand data is always resolved from brand.json or the
registry at execution time.
- Delete brand-manifest.json and brand-manifest-ref.json schemas
- Upgrade brand.json brand object with url, contact, richer logos/assets
- Replace brand_manifest field with brand (BrandRef) in all task schemas
- Update brand-ref.json: house → domain, brand_id optional
- Add resolveBrandRef() to brand manager and getDiscoveredBrandByRef() to DB
- Add brand_id column to discovered_brands (migration 225)
- Update 40+ docs/skill files: brand_manifest → brand references
- Delete docs/creative/brand-manifest.mdx, update docs.json navigation
BREAKING CHANGE: brand_manifest field replaced with brand ({ domain, brand_id })
in get_products, create_media_buy, build_creative, and property list schemas.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Rebuild dist/schemas/3.0.0-beta.3/ bundled schemas from updated source (bundled create-media-buy-request.json still required brand_manifest) - Sync dist/docs/3.0.0-beta.3/ snapshot with current source docs (snapshot had stale brand-manifest references and deleted page) - Add redirect /docs/creative/brand-manifest → /docs/brand-protocol/brand-json (handles broken links in 2.5.3 versioned docs) - Fix composed schema test regex to match prerelease versions Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
bokelley
changed the title
- Revert dist/ changes from previous fix commit — dist/ snapshots are frozen release artifacts, not updated on every source change - Fix composed schema test: only use latest/ (dev build), never fall back to versioned dirs in dist/ which may be from a prior release - Redirect /docs/creative/brand-manifest → /docs/brand-protocol/brand-json to handle broken links in versioned doc snapshots without modifying them Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Migration 225_addie_partner_directory_taxonomy.sql was merged to main after this branch was created. Renaming brand_ref_support to 229 to be the next available number after 228_rate_limit_store.sql. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
brand-manifest.jsonandbrand-manifest-ref.json— the brand object inbrand.jsonis now the single canonical brand definitionbrand.jsonwith fields previously only in brand-manifest.json (url,contact, richer logo/asset enums)brand_manifestwithbrand(abrand-ref.jsonreference withdomain+ optionalbrand_id) in all 7 task schemas — agents always resolve brand identity at execution time rather than receiving inline manifestsbrand-ref.jsonto usedomain(required) +brand_id(optional) instead ofhouse+brand_idresolveBrandRef(), update all 4 tool handlers, remove brand-manifest from schema catalogbrand_idcolumn andgetDiscoveredBrandByRef()methodCloses #1114
Test plan
npm test) — schemas, examples, composed, unit (297), typecheck🤖 Generated with Claude Code