Parse Tags like in GenerateResourcesAndImage.ps1#12770
Open
YannickRe wants to merge 1 commit intoactions:mainfrom
Open
Parse Tags like in GenerateResourcesAndImage.ps1#12770YannickRe wants to merge 1 commit intoactions:mainfrom
YannickRe wants to merge 1 commit intoactions:mainfrom
Conversation
Adjust the logic of dealing with Tags in a way that is an exact copy of the logic within GenerateResourcesAndImage.ps1 . This solves a parsing error.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a parsing error by aligning the tag handling logic with the implementation from GenerateResourcesAndImage.ps1. The change ensures proper JSON escaping of tags based on the PowerShell version being used.
- Updates tag processing to handle JSON escaping properly across different PowerShell versions
- Replaces direct JSON conversion with version-specific string escaping logic
- Renames the variable from
azure_tagstoTagsJsonfor clarity
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Author
|
Copilot is being stupid here, the point is to do that exact string replacement... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bug fixing. Adjust the logic of dealing with Tags in a way that is an exact copy of the logic within GenerateResourcesAndImage.ps1 . This solves a parsing error.
Related issue:
Check list