WIP: Update packages so that they can be generated via JSON files#154
Open
WIP: Update packages so that they can be generated via JSON files#154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes it so that we keep track of chains/tokens in JSON files rather than typescript files.
The code in
scripts/can be used to generate corresponding Python/Rust/Typescript packages. The code generates new code so that we don't lose the benefits of having constant values (i.e. we don't have to dynamically read a json file).I've tested most pieces of this so far but, given the centrality of this package, it merits additional (and extensive) investigation.
TLDR: THIS IS NOT READY TO MERGE YET.