Fix codestudio wizard in timezones that are UTC+N#1964
Open
larowlan wants to merge 1 commit intoacquia:mainfrom
Open
Fix codestudio wizard in timezones that are UTC+N#1964larowlan wants to merge 1 commit intoacquia:mainfrom
larowlan wants to merge 1 commit intoacquia:mainfrom
Conversation
danepowell
requested changes
Feb 18, 2026
Contributor
danepowell
left a comment
There was a problem hiding this comment.
Great find, thanks a lot for the PR.
Seems like you might need to use DateTimeZone; to make this work.
If you can get tests passing, I'd be very happy to merge this.
Author
|
yeah I did this in the github UI, needs a leading |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Attempting to use the wizard in any timezone that is ahead of UTC throws a 400 bad request from gitlab because of date handling that doesn't take into account the default timezone setting in PHP
400 Bad request - Expiration date must be before 2027-02-17Proposed changes
Makes sure the date set is in UTC
Alternatives considered
Testing steps
Edit php.ini and set your timezone to something ahead of the international date line - e.g.
date.timezone = Australia/BrisbaneRun the cs:wizard command before UTC ticks over (e.g. before 10 am in the case of Brisbane).
Get the above error.
Change your timezone to UTC and it works.
Fix avoids need to do that