Skip to content

fix: return 422 for invalid historyLength in REST get_task #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
azilbersteinSFDC wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: return 422 for invalid historyLength in REST get_task #741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ccf971c
fix: return 422 for invalid historyLength in REST get_task
azilbersteinSFDC Feb 26, 2026
c30717e
fix: address ruff lint (import order, B904 exception chaining)
azilbersteinSFDC Feb 26, 2026
0effc0f
style: ruff format
azilbersteinSFDC Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/a2a/server/request_handlers/rest_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from typing import TYPE_CHECKING, Any

from google.protobuf.json_format import MessageToDict, MessageToJson, Parse
from pydantic import ValidationError


if TYPE_CHECKING:
Expand All @@ -21,6 +22,7 @@
from a2a.types import (
AgentCard,
GetTaskPushNotificationConfigParams,
InvalidParamsError,
TaskIdParams,
TaskNotFoundError,
TaskQueryParams,
Expand Down Expand Up @@ -257,8 +259,19 @@ async def on_get_task(
"""
task_id = request.path_params['id']
history_length_str = request.query_params.get('historyLength')
history_length = int(history_length_str) if history_length_str else None
params = TaskQueryParams(id=task_id, history_length=history_length)
try:
params = TaskQueryParams(
id=task_id,
history_length=history_length_str
if history_length_str
else None,
)
except ValidationError:
raise ServerError(
error=InvalidParamsError(
message='historyLength must be a valid integer'
)
) from None
task = await self.request_handler.on_get_task(params, context)
if task:
return MessageToDict(proto_utils.ToProto.task(task))
Expand Down
12 changes: 12 additions & 0 deletions tests/server/apps/rest/test_rest_fastapi_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,5 +399,17 @@ async def test_send_message_rejected_task(
assert expected_response == actual_response


@pytest.mark.anyio
async def test_get_task_invalid_history_length_returns_422(
client: AsyncClient,
) -> None:
"""Non-numeric historyLength query param returns 422 InvalidParamsError."""
response = await client.get('/v1/tasks/some-task-id?historyLength=abc')
assert response.status_code == 422
data = response.json()
assert 'message' in data
assert 'historylength' in data['message'].lower()


if __name__ == '__main__':
pytest.main([__file__])
Loading