Skip to content

[WIP] Don't use menubuttons where we don't want buttons#411

Draft
trigg wants to merge 4 commits intomasterfrom
less-buttons
Draft

[WIP] Don't use menubuttons where we don't want buttons#411
trigg wants to merge 4 commits intomasterfrom
less-buttons

Conversation

@trigg
Copy link
Collaborator

@trigg trigg commented Mar 21, 2026

Refactor internal WayfireMenuButton to no longer actually be a menu button

We put a fair bit of extra code to make MenuButton not actually be a menubutton. So this PR will standardise an interface for all Popup-based widgets without each one having to fight to not look like a button

Advantages over not having this PR:

  • Fixed popover too big for entire screen at the source
  • Moved autohide and layer shell logic out of individual widgets.
  • Added option for popup-menu to follow mouse across other popup-menu widgets.

TODOs:

  • Reimplement menu fullscreen option
  • add some form of css class to signify a widget has a popup shown currently
  • add css class to signify it has a popup available to be shown (and unset when not menu and 0 children in popup)

trigg added 4 commits March 21, 2026 18:42
panel: start standardising on popups
panel: fix popup too big for screen
panel: fix menu crash before init
panel: made menu-follows-mouse an option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant