fix(release): handle pipefail in sandbox creation for strict mode#589
Merged
Chemaclass merged 1 commit intomainfrom Feb 13, 2026
Merged
fix(release): handle pipefail in sandbox creation for strict mode#589Chemaclass merged 1 commit intomainfrom
Chemaclass merged 1 commit intomainfrom
Conversation
set +e alone doesn't disable pipefail, causing tar pipe failures to propagate in strict mode. Use subshell + || pattern instead to isolate shell option changes from the caller.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set +ealone doesn't disablepipefail, causing tar pipe failures to propagate in strict mode||pattern to isolate shell option changes from the callercpfallback with|| truefor transient files during parallel executionTest plan
./bashunit --strict tests/unit/release_sandbox_test.shpasses./bashunit --parallel --simple --strict tests/passes (750 tests, 0 failures)make sapasses (ShellCheck)