Conversation
a265a14 to
6229e7f
Compare
6229e7f to
26bcb0b
Compare
26bcb0b to
cf6d83a
Compare
cf6d83a to
5579937
Compare
3e8c20a to
81c9329
Compare
d9b511e to
a232af7
Compare
a232af7 to
00abc5f
Compare
00abc5f to
b68f812
Compare
|
@epatters This test fails, but for "bad reasons" — the models are indeed actually the same, but they are ordered differently. Would you prefer me to
I suppose that one thing that (3) could be is building a visualisation analysis that displays the CLD, but this is roughly as non-trivial as (2) imho (for somebody like me), so I'd rather save that specific suggestion for a future PR |
b68f812 to
99b2aa2
Compare
7190fda to
45006a8
Compare
|
@tim-at-topos, is this one still blocked on me? If you want to pick this back up, I can try to debug why your test is failing. |
|
From memory (and my unhelpful commit messages), I made the tests pass in the end by checking for equality of models by just iterating over all Aside from that, I guess I'm happy to ask for this PR to be considered for merging, but I must admit that I haven't yet figured out the next step. The original plan was to just preview the migrated model in an analysis, which seems like something that would be generally useful (i.e. making analyses work with a derived model of a model rather than just the model itself). To actually allow users to migrate along this migration was blocked by us figuring out how we wanted derived models to behave (maybe something that deserves an RFC?). |
To-do: