Open
Conversation
8480aa7 to
a950774
Compare
jmoggr
approved these changes
Mar 17, 2026
Collaborator
jmoggr
left a comment
There was a problem hiding this comment.
Those instructions appear for hash mismatches that are not related to pnpm. pnpm.fetchDeps rolls their own hash checking, so it has a non-standard error message. I'll open a follow up PR with this clarification.
Member
Author
|
Wait, why do we set the |
Collaborator
|
Yeah... we only need to do that for non |
Collaborator
|
I'm working on the fixes, I'll push them here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are a bit too wordy for a situation where we normally "just want to get the check to pass". Also they talk about "instructions given below the error message" which don't seem to exist.