Skip to content

Tighten up docs on hash mismatch#1138

Open
kasbah wants to merge 1 commit intomainfrom
kb/docs-hash-mismatch
Open

Tighten up docs on hash mismatch#1138
kasbah wants to merge 1 commit intomainfrom
kb/docs-hash-mismatch

Conversation

@kasbah
Copy link
Member

@kasbah kasbah commented Mar 17, 2026

These are a bit too wordy for a situation where we normally "just want to get the check to pass". Also they talk about "instructions given below the error message" which don't seem to exist.

@kasbah kasbah added the documentation Improvements or additions to documentation label Mar 17, 2026
@kasbah kasbah marked this pull request as ready for review March 17, 2026 14:21
@kasbah kasbah requested a review from jmoggr March 17, 2026 14:22
Copy link
Collaborator

@jmoggr jmoggr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those instructions appear for hash mismatches that are not related to pnpm. pnpm.fetchDeps rolls their own hash checking, so it has a non-standard error message. I'll open a follow up PR with this clarification.

@kasbah
Copy link
Member Author

kasbah commented Mar 17, 2026

Wait, why do we set the pnpmDeps.hash to empty? I just ran it without doing that and it tells me the hash that I need to copy in.


$ nix build .#frontend
error: hash mismatch in fixed-output derivation '/nix/store/4wpp80j18vvm232ii1ajl2kqnbfgvzq2-frontend-pnpm-deps.drv':
         specified: sha256-vuBwhtNTTRbpgPZS+AQDybASYM9rwWYG8l0bscVQUso=
            got:    sha256-sxczRF8IsYqQzmAAv+IiFeWJygqHCVnSk8fEuy5d1JM=

@jmoggr
Copy link
Collaborator

jmoggr commented Mar 17, 2026

Yeah... we only need to do that for non pnpm.fetchDeps hashes, since pnpm.fetchDeps is special (with nicer behavior!). At the time I wrote the docs there were more "standard" hash mismatch issues and I muddled up the issues in the docs. The instructions will still get you the same results.

@jmoggr
Copy link
Collaborator

jmoggr commented Mar 17, 2026

I'm working on the fixes, I'll push them here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants