Open
Conversation
KevinDCarlson
commented
Feb 19, 2026
| InvalidFpCategory::Dom(e) => Invalid::Dom(e), | ||
| InvalidFpCategory::Cod(e) => Invalid::Cod(e), | ||
| InvalidFpCategory::Eq(eq, errs) => Invalid::Eq(eq, errs), | ||
| InvalidFpCategory::Eqn(eq, errs) => Invalid::Eqn(Some(eq), errs), |
Collaborator
Author
There was a problem hiding this comment.
I changed these two kinds of "Eq" to "Eqn" because "Eq" is used so often in Rust.
KevinDCarlson
changed the base branch from
main
to
equations_in_notebook_types
epatters
added
enhancement
KevinDCarlson
force-pushed
the
equations_in_notebook_types
branch
2 times, most recently
from
0f76c07 to
342933e
Compare
KevinDCarlson
force-pushed
the
notebook_elaborator
branch
from
8d315a1 to
1f49909
Compare
KevinDCarlson
force-pushed
the
equations_in_notebook_types
branch
from
cffcd0d to
20606f3
Compare
Member
KevinDCarlson
force-pushed
the
notebook_elaborator
branch
from
1f49909 to
718dc5e
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1047 and #1060. Elaboration of notebooks containing equations to the type theory. Note that the diffs to modules in
ttother thannotebook_evalitself are spurious, due to the double parentage.