tests(algorithms): ensure cross-policy consistency and add missing edge cases#7175
Open
aneek22112007-tech wants to merge 5 commits intoTheHPXProject:masterfrom
Conversation
|
Can one of the admins verify this patch? |
Up to standards ✅🟢 Issues
|
aneek22112007-tech
force-pushed
the
test/cross-policy-consistency-search-algorithms
branch
from
50e3a9d to
e1239e0
Compare
Contributor
|
@aneek22112007-tech Please have a look at the inspect issues reported. |
aneek22112007-tech
force-pushed
the
test/cross-policy-consistency-search-algorithms
branch
from
e1239e0 to
d27bc0d
Compare
Contributor
Author
@hkaiser Thanks for catching that! The inspect issue was caused by some non-ASCII em-dashes (—) in my code comments. I've stripped them out and forced an update to the branch. The inspect checks should be green now! |
aneek22112007-tech
force-pushed
the
test/cross-policy-consistency-search-algorithms
branch
from
d27bc0d to
8c687ea
Compare
…ion tests - hpx::find: add test_find_cross_policy covering 7 deterministic datasets (empty range, single element match/no-match, boundary-0, boundary-N, no match anywhere, multiple matches) across seq/par/par_unseq - hpx::find_if: add test_find_if_cross_policy with identical 7-dataset harness; remove stale debug std::cout left in test_find_if_async - hpx::find_first_of: add test_find_first_of_empty_needle verifying the C++ standard mandate that an empty needle range returns first (exercised per policy); add test_find_first_of_cross_policy as a direct regression guard for the historical inner-loop non-short-circuit bug - hpx::mismatch: add test_mismatch_cross_policy extending empty-range coverage from the HPX_HAVE_STDEXEC-only sender path to seq/par/par_unseq - hpx::experimental::reduce_by_key: add three boundary condition tests: empty input, single key group (all keys identical), all-unique keys No API or implementation changes. Pure test additions.
aneek22112007-tech
force-pushed
the
test/cross-policy-consistency-search-algorithms
branch
2 times, most recently
from
6aeebc8 to
191eb2a
Compare
Contributor
|
@aneek22112007-tech inspect is still not happy: |
aneek22112007-tech
force-pushed
the
test/cross-policy-consistency-search-algorithms
branch
from
191eb2a to
5fdcbcd
Compare
aneek22112007-tech
force-pushed
the
test/cross-policy-consistency-search-algorithms
branch
from
5fdcbcd to
66175f1
Compare
Contributor
Author
@hkaiser Good catch! I missed the <type_traits> header for std::is_same_v when I pulled out the edge case tests earlier. I've just added the include and forced an update. Hopefully, inspect is happy this time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on the recent
find_first_ofearly-termination fix, I noticed that our test suite doesn't explicitly verify thatseq,par, andpar_unseqreturn identical results for the exact same inputs. It also missed a few basic boundary conditions (like the "not found" path for parallel execution).This PR adds some straightforward regression tests to make sure the standard execution policies never diverge from the sequential behavior. No API or implementation logic was changed.
Changes:
find&find_if: Added a cross-policy helper that checks 7 deterministic scenarios (empty range, single element, partition boundaries, complete miss, and multiple matches). Also removed a leftoverstd::coutdebug print infindif_tests.hpp.find_first_of: Added standard-compliance checks for empty needle ranges. Added a cross-policy test that acts as a direct regression guard for the recent inner-loop short-circuiting bug.mismatch: The empty-range test was previously only running under theHPX_HAVE_STDEXECsender path. Extended this to run forseq,par, andpar_unseq.reduce_by_key: Added basic boundary tests for empty inputs, all-identical keys (single group), and all-unique keys.These additions should give us a bit more confidence when tweaking or optimizing the parallel algorithm implementations in the future.